public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [2.6 patch] drivers/char/mwave/3780i.c: cleanups
@ 2005-04-30 20:08 Adrian Bunk
  0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-04-30 20:08 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel

This patch contains the following cleanups:
- make a needlessly global function static
- #if 0 the unused global function dsp3780I_ReadGenCfg

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

This patch was already sent on:
- 17 Apr 2005

 drivers/char/mwave/3780i.c |    6 ++++--
 drivers/char/mwave/3780i.h |    4 ----
 2 files changed, 4 insertions(+), 6 deletions(-)

--- linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.h.old	2005-04-17 18:12:29.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.h	2005-04-17 18:13:16.000000000 +0200
@@ -338,10 +338,6 @@
                                    unsigned long ulMsaAddr);
 void dsp3780I_WriteMsaCfg(unsigned short usDspBaseIO,
                           unsigned long ulMsaAddr, unsigned short usValue);
-void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
-                          unsigned char ucValue);
-unsigned char dsp3780I_ReadGenCfg(unsigned short usDspBaseIO,
-                                  unsigned uIndex);
 int dsp3780I_GetIPCSource(unsigned short usDspBaseIO,
                           unsigned short *pusIPCSource);
 
--- linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.c.old	2005-04-17 18:12:49.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.c	2005-04-17 18:13:33.000000000 +0200
@@ -107,8 +107,8 @@
 	spin_unlock_irqrestore(&dsp_lock, flags);
 }
 
-void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
-                          unsigned char ucValue)
+static void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
+				 unsigned char ucValue)
 {
 	DSP_ISA_SLAVE_CONTROL rSlaveControl;
 	DSP_ISA_SLAVE_CONTROL rSlaveControl_Save;
@@ -141,6 +141,7 @@
 
 }
 
+#if 0
 unsigned char dsp3780I_ReadGenCfg(unsigned short usDspBaseIO,
                                   unsigned uIndex)
 {
@@ -167,6 +168,7 @@
 
 	return ucValue;
 }
+#endif  /*  0  */
 
 int dsp3780I_EnableDSP(DSP_3780I_CONFIG_SETTINGS * pSettings,
                        unsigned short *pIrqMap,


^ permalink raw reply	[flat|nested] 2+ messages in thread
* [2.6 patch] drivers/char/mwave/3780i.c: cleanups
@ 2005-04-17 20:09 Adrian Bunk
  0 siblings, 0 replies; 2+ messages in thread
From: Adrian Bunk @ 2005-04-17 20:09 UTC (permalink / raw)
  To: linux-kernel

This patch contains the following cleanups:
- make a needlessly global function static
- #if 0 the unused global function dsp3780I_ReadGenCfg

Signed-off-by: Adrian Bunk <bunk@stusta.de>

---

 drivers/char/mwave/3780i.c |    6 ++++--
 drivers/char/mwave/3780i.h |    4 ----
 2 files changed, 4 insertions(+), 6 deletions(-)

--- linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.h.old	2005-04-17 18:12:29.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.h	2005-04-17 18:13:16.000000000 +0200
@@ -338,10 +338,6 @@
                                    unsigned long ulMsaAddr);
 void dsp3780I_WriteMsaCfg(unsigned short usDspBaseIO,
                           unsigned long ulMsaAddr, unsigned short usValue);
-void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
-                          unsigned char ucValue);
-unsigned char dsp3780I_ReadGenCfg(unsigned short usDspBaseIO,
-                                  unsigned uIndex);
 int dsp3780I_GetIPCSource(unsigned short usDspBaseIO,
                           unsigned short *pusIPCSource);
 
--- linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.c.old	2005-04-17 18:12:49.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/mwave/3780i.c	2005-04-17 18:13:33.000000000 +0200
@@ -107,8 +107,8 @@
 	spin_unlock_irqrestore(&dsp_lock, flags);
 }
 
-void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
-                          unsigned char ucValue)
+static void dsp3780I_WriteGenCfg(unsigned short usDspBaseIO, unsigned uIndex,
+				 unsigned char ucValue)
 {
 	DSP_ISA_SLAVE_CONTROL rSlaveControl;
 	DSP_ISA_SLAVE_CONTROL rSlaveControl_Save;
@@ -141,6 +141,7 @@
 
 }
 
+#if 0
 unsigned char dsp3780I_ReadGenCfg(unsigned short usDspBaseIO,
                                   unsigned uIndex)
 {
@@ -167,6 +168,7 @@
 
 	return ucValue;
 }
+#endif  /*  0  */
 
 int dsp3780I_EnableDSP(DSP_3780I_CONFIG_SETTINGS * pSettings,
                        unsigned short *pIrqMap,


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2005-04-30 20:10 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-30 20:08 [2.6 patch] drivers/char/mwave/3780i.c: cleanups Adrian Bunk
  -- strict thread matches above, loose matches on Subject: below --
2005-04-17 20:09 Adrian Bunk

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox