From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>
Cc: linux-kernel@vger.kernel.org
Subject: [2.6 patch] drivers/char/nvram.c: possible cleanups
Date: Sat, 30 Apr 2005 22:08:11 +0200 [thread overview]
Message-ID: <20050430200811.GP3571@stusta.de> (raw)
This patch contains the following possible cleanups:
- make the needlessly global function __nvram_set_checksum static
- #if 0 the unused global function nvram_set_checksum
- remove the EXPORT_SYMBOL's for both functions
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 17 Apr 2005
drivers/char/nvram.c | 6 +++---
include/linux/nvram.h | 2 --
2 files changed, 3 insertions(+), 5 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/linux/nvram.h.old 2005-04-17 18:15:57.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/linux/nvram.h 2005-04-17 18:16:04.000000000 +0200
@@ -20,8 +20,6 @@
extern void nvram_write_byte(unsigned char c, int i);
extern int __nvram_check_checksum(void);
extern int nvram_check_checksum(void);
-extern void __nvram_set_checksum(void);
-extern void nvram_set_checksum(void);
#endif
#endif /* _LINUX_NVRAM_H */
--- linux-2.6.12-rc2-mm3-full/drivers/char/nvram.c.old 2005-04-17 18:16:10.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/nvram.c 2005-04-17 18:16:36.000000000 +0200
@@ -211,12 +211,13 @@
return rv;
}
-void
+static void
__nvram_set_checksum(void)
{
mach_set_checksum();
}
+#if 0
void
nvram_set_checksum(void)
{
@@ -226,6 +227,7 @@
__nvram_set_checksum();
spin_unlock_irqrestore(&rtc_lock, flags);
}
+#endif /* 0 */
/*
* The are the file operation function for user access to /dev/nvram
@@ -921,6 +923,4 @@
EXPORT_SYMBOL(nvram_write_byte);
EXPORT_SYMBOL(__nvram_check_checksum);
EXPORT_SYMBOL(nvram_check_checksum);
-EXPORT_SYMBOL(__nvram_set_checksum);
-EXPORT_SYMBOL(nvram_set_checksum);
MODULE_ALIAS_MISCDEV(NVRAM_MINOR);
next reply other threads:[~2005-04-30 20:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-30 20:08 Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-04-17 20:11 [2.6 patch] drivers/char/nvram.c: possible cleanups Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050430200811.GP3571@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox