* [2.6 patch] drivers/char/tty_io.c: make a function static
@ 2005-04-30 20:08 Adrian Bunk
2005-04-30 21:59 ` Andrew Morton
0 siblings, 1 reply; 4+ messages in thread
From: Adrian Bunk @ 2005-04-30 20:08 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
This patch makes a needlessly global function static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
This patch was already sent on:
- 17 Apr 2005
drivers/char/tty_io.c | 5 +++--
include/linux/tty.h | 2 --
2 files changed, 3 insertions(+), 4 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/linux/tty.h.old 2005-04-17 18:30:17.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/linux/tty.h 2005-04-17 18:30:24.000000000 +0200
@@ -337,8 +337,6 @@
extern void console_init(void);
extern int vcs_init(void);
-extern int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
- const char *routine);
extern char *tty_name(struct tty_struct *tty, char *buf);
extern void tty_wait_until_sent(struct tty_struct * tty, long timeout);
extern int tty_check_change(struct tty_struct * tty);
--- linux-2.6.12-rc2-mm3-full/drivers/char/tty_io.c.old 2005-04-17 18:30:32.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/tty_io.c 2005-04-17 18:30:51.000000000 +0200
@@ -186,8 +186,9 @@
EXPORT_SYMBOL(tty_name);
-inline int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
- const char *routine)
+static inline int tty_paranoia_check(struct tty_struct *tty,
+ struct inode *inode,
+ const char *routine)
{
#ifdef TTY_PARANOIA_CHECK
if (!tty) {
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [2.6 patch] drivers/char/tty_io.c: make a function static
2005-04-30 20:08 [2.6 patch] drivers/char/tty_io.c: make a function static Adrian Bunk
@ 2005-04-30 21:59 ` Andrew Morton
2005-04-30 23:39 ` Adrian Bunk
0 siblings, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2005-04-30 21:59 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-kernel
Adrian Bunk <bunk@stusta.de> wrote:
>
> This patch makes a needlessly global function static.
>
> ...
> -extern int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
> - const char *routine);
Is used in fs/compat_ioct.c.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] drivers/char/tty_io.c: make a function static
2005-04-30 21:59 ` Andrew Morton
@ 2005-04-30 23:39 ` Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-04-30 23:39 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel
On Sat, Apr 30, 2005 at 02:59:07PM -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > This patch makes a needlessly global function static.
> >
> > ...
> > -extern int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
> > - const char *routine);
>
> Is used in fs/compat_ioct.c.
Sorry.
I missed this while grepping and it didn't show up in my i386 test
compiles.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 4+ messages in thread
* [2.6 patch] drivers/char/tty_io.c: make a function static
@ 2005-04-17 20:20 Adrian Bunk
0 siblings, 0 replies; 4+ messages in thread
From: Adrian Bunk @ 2005-04-17 20:20 UTC (permalink / raw)
To: linux-kernel
This patch makes a needlessly global function static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/char/tty_io.c | 5 +++--
include/linux/tty.h | 2 --
2 files changed, 3 insertions(+), 4 deletions(-)
--- linux-2.6.12-rc2-mm3-full/include/linux/tty.h.old 2005-04-17 18:30:17.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/include/linux/tty.h 2005-04-17 18:30:24.000000000 +0200
@@ -337,8 +337,6 @@
extern void console_init(void);
extern int vcs_init(void);
-extern int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
- const char *routine);
extern char *tty_name(struct tty_struct *tty, char *buf);
extern void tty_wait_until_sent(struct tty_struct * tty, long timeout);
extern int tty_check_change(struct tty_struct * tty);
--- linux-2.6.12-rc2-mm3-full/drivers/char/tty_io.c.old 2005-04-17 18:30:32.000000000 +0200
+++ linux-2.6.12-rc2-mm3-full/drivers/char/tty_io.c 2005-04-17 18:30:51.000000000 +0200
@@ -186,8 +186,9 @@
EXPORT_SYMBOL(tty_name);
-inline int tty_paranoia_check(struct tty_struct *tty, struct inode *inode,
- const char *routine)
+static inline int tty_paranoia_check(struct tty_struct *tty,
+ struct inode *inode,
+ const char *routine)
{
#ifdef TTY_PARANOIA_CHECK
if (!tty) {
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2005-04-30 23:39 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-04-30 20:08 [2.6 patch] drivers/char/tty_io.c: make a function static Adrian Bunk
2005-04-30 21:59 ` Andrew Morton
2005-04-30 23:39 ` Adrian Bunk
-- strict thread matches above, loose matches on Subject: below --
2005-04-17 20:20 Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox