From: Natalie.Protasevich@unisys.com
To: akpm@osdl.org
Cc: ak@muc.de, len.brown@intel.com, venkatesh.pallipadi@intel.com,
linux-kernel@vger.kernel.org, zwane@arm.linux.org.uk,
Natalie.Protasevich@unisys.com
Subject: [patch 1/1] Added NO_IOAPIC_CHECK in io_apic_get_unique_id() for ACPI boot
Date: Sun, 01 May 2005 03:54:33 -0700 [thread overview]
Message-ID: <20050501105434.2B95E42AD7@linux.site> (raw)
This patch allows xAPIC systems that don't have serial bus for interrupts delivery to by-pass the check on uniquness of IO-APIC IDs. Some of ES7000's panic failing this unnecessary check. The genapic mechanism has NO_IOAPIC_CHECK flag, which is defined in each subarch. The MP boot utilizes it, but the ACPI boot is missing it.
Signed-off by: Natalie Protasevich <Natalie.Protasevich@unisys.com>
---
diff -puN arch/i386/kernel/io_apic.c~no-ioapic-check arch/i386/kernel/io_apic.c
--- linux-2.6.13-rc3-mm2/arch/i386/kernel/io_apic.c~no-ioapic-check 2005-05-01 02:15:48.054362032 -0700
+++ linux-2.6.13-rc3-mm2-root/arch/i386/kernel/io_apic.c 2005-05-01 02:28:23.282549896 -0700
@@ -2436,13 +2436,18 @@ int __init io_apic_get_unique_id (int io
unsigned long flags;
int i = 0;
+ /* Don't check I/O APIC IDs for some xAPIC systems. They have
+ * no meaning without the serial APIC bus.
+ */
+
+ if (NO_IOAPIC_CHECK)
+ return apic_id;
+
/*
* The P4 platform supports up to 256 APIC IDs on two separate APIC
* buses (one for LAPICs, one for IOAPICs), where predecessors only
* supports up to 16 on one shared APIC bus.
*
- * TBD: Expand LAPIC/IOAPIC support on P4-class systems to take full
- * advantage of new APIC bus architecture.
*/
if (physids_empty(apic_id_map))
_
next reply other threads:[~2005-05-02 5:58 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-01 10:54 Natalie.Protasevich [this message]
2005-05-03 2:53 ` [patch 1/1] Added NO_IOAPIC_CHECK in io_apic_get_unique_id() for ACPI boot Zwane Mwaikambo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050501105434.2B95E42AD7@linux.site \
--to=natalie.protasevich@unisys.com \
--cc=ak@muc.de \
--cc=akpm@osdl.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=venkatesh.pallipadi@intel.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox