The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Colin Leroy <colin@colino.net>
To: Chris Wedgwood <cw@f00f.org>
Cc: Roman Zippel <zippel@linux-m68k.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH] hfsplus: don't oops on bad FS
Date: Sun, 1 May 2005 11:12:33 +0200	[thread overview]
Message-ID: <20050501111233.5c638ff7@jack.colino.net> (raw)
In-Reply-To: <20050501050833.GA3045@taniwha.stupidest.org>

On 30 Apr 2005 at 22h04, Chris Wedgwood wrote:

Hi, 

> > +cleanup_little:
> >  	if (nls)
> >  		unload_nls(nls);
> > +	sb->s_fs_info = NULL;
> > +	kfree(sbi);
> 
> cleanup_little?  why not cleanup_no_put or something?

I was lacking this kind of inspiration :)
Roman's patch that Andrew just pushed superceded this one, anyway.

-- 
Colin

      reply	other threads:[~2005-05-01  9:12 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20050425211915.126ddab5@jack.colino.net>
2005-04-25 19:53 ` [PATCH] hfsplus: don't oops on bad FS Roman Zippel
2005-04-25 20:03   ` Colin Leroy
2005-04-25 20:07     ` Christoph Hellwig
2005-04-25 20:12       ` Colin Leroy
2005-04-25 20:26     ` Roman Zippel
2005-04-26  6:59       ` Colin Leroy
2005-04-26  7:14         ` Colin Leroy
2005-04-25 20:29     ` Jesper Juhl
2005-05-01  5:08     ` Chris Wedgwood
2005-05-01  9:12       ` Colin Leroy [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050501111233.5c638ff7@jack.colino.net \
    --to=colin@colino.net \
    --cc=akpm@osdl.org \
    --cc=cw@f00f.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox