From: Adrian Bunk <bunk@stusta.de>
To: Gerd Knorr <kraxel@bytesex.org>
Cc: 2003 John Klar <linpvr@projectplasma.com>,
linux-kernel@vger.kernel.org, video4linux-list@redhat.com
Subject: Re: [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups
Date: Sun, 1 May 2005 16:23:30 +0200 [thread overview]
Message-ID: <20050501142330.GE3592@stusta.de> (raw)
In-Reply-To: <20050419075348.GD15656@bytesex>
On Tue, Apr 19, 2005 at 09:53:48AM +0200, Gerd Knorr wrote:
> > - #if 0 the EXPORT_SYMBOL'ed but unused function tveeprom_dump
>
> That's a debug helper function, please don't drop it. #if 0 might be
> ok, not sure though, the tveeprom module is also used by a out-of-kernel
> driver (ivtv). Otherwise the patch looks fine to me.
As the comment says, my patch does #if 0 the function.
> Gerd
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2005-05-01 14:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-04-19 0:53 [2.6 patch] drivers/media/video/tveeprom.c: possible cleanups Adrian Bunk
2005-04-19 7:53 ` Gerd Knorr
2005-05-01 14:23 ` Adrian Bunk [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-07-09 3:07 Adrian Bunk
2005-07-15 21:35 Adrian Bunk
2005-07-15 22:29 ` Mauro Carvalho Chehab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050501142330.GE3592@stusta.de \
--to=bunk@stusta.de \
--cc=kraxel@bytesex.org \
--cc=linpvr@projectplasma.com \
--cc=linux-kernel@vger.kernel.org \
--cc=video4linux-list@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox