Re: [PATCH]porting lockless mce from x86_64 to i386

[Andi Kleen <ak@muc.de>]

On Mon, May 02, 2005 at 09:15:07AM -0700, Pallipadi, Venkatesh wrote:
> >-----Original Message-----
> >From: linux-kernel-owner@vger.kernel.org 
> >[mailto:linux-kernel-owner@vger.kernel.org] On Behalf Of Guo, Racing
> >Sent: Sunday, May 01, 2005 6:02 PM
> >To: Andi Kleen; Andrew Morton
> >Cc: Yu, Luming; linux-kernel@vger.kernel.org
> >Subject: RE: [PATCH]porting lockless mce from x86_64 to i386
> >
> >>
> >>If Luming would not move the mce.c file from x86-64 to i386 then
> >>his patch would be only 1/4 as big. I dont know why he does this
> >>anyways, it seems completely pointless.
> >
> >mce.c mce.h and mce_intel.c are moved from x86_64 to i386. so the
> >patch is very big. The motivation is to share mce code between
> >x86_64 and i386 and avoid duplicate code in x86_64 and i386.
> >I don't know whether I completely understand what you point.
> >Correct me if I am wrong.
> 
> I think what Andi meant was that instead of copying code from x86-64 
> to i386 and making x86-64 link to this i386 copy, you can leave the 
> code in x86-64 and link it from i386 part of the tree. 

Yep.

> 
> Doing it either way should be OK with this mce code. But I feel, 
> despite of the patch size, it is better to keep all the shared 
> code in i386 tree and link it from x86-64. Otherwise, it may become 
> kind of messy in future, with various links between i386 and x86-64.

i386 already uses code from x86-64 (earlyprintk.c) - it is nothing 
new.


-Andi