Re: [PATCH 1/22] UML - Include the linker script rather than symlink it

Andrew Morton
2005-05-03T02:03:33Z

Al Viro <viro@parcelfarce.linux.theplanet.co.uk> wrote:
>
> On Mon, May 02, 2005 at 06:28:51PM -0700, Andrew Morton wrote:
> > # Copyright 2003 - 2004 Pathscale, Inc
> > # Released under the GPL
> >
> > hostprogs-y := mk_sc mk_thread
> > always := $(hostprogs-y)
> >
> > HOSTCFLAGS_mk_thread.o := -I$(objtree)/arch/um
>
> > Is mk_sc still supposed to be in there?
>
> Yes, along with hostflags for it.

Ah, OK.

> > > how the hell did the latter manage to apply at all?)
> >
> > I just "fixed" things. I do it all the time.
>
> Erm... "Gives rejects" => "ought to investigate" => "bugger it, let
> submitter figure it out and resubmit" would be an obvious progression...

Sometimes. Most of the time it's less work (and much less latency) just to
fix stuff up.

> OK. Please, pick the following patches:
> UM0-uml-ldscript-RC12-rc3
> UM1-uml-os-RC12-rc3
> UM2-uml-user-constants-RC12-rc3
> UM3-uml-ptregs-RC12-rc3
> UM4-uml-sc-RC12-rc3
> UM5-uml-kernel-offsets-RC12-rc3
> UM6-uml-thread-RC12-rc3
> UM7-uml-util-RC12-rc3
> UM8-uml-clean-RC12-rc3
> UM10-uml-O-RC12-rc3
> in ftp.linux.org.uk/pub/people/viro. In the order above. That's where
> the beginning of Jeff's series had come from (his 1--9 and 4.5).

OK, did that. Had one reject against
uml-kbuild-avoid-useless-rebuilds.patch, but 'twas easily fixed.