Re: [PATCH] DAC960: add support for Mylex AcceleRAID 4/5/600

[Andrew Morton <akpm@osdl.org>]

Christoph Hellwig <hch@lst.de> wrote:
>
> > This patch adds support for a new class of DAC960 controllers.  It's
> > based on the GPLed idac320 driver from IBM for Linux 2.4.18.  That
> > driver is a fork of the 2.4.18 version of DAC960 that adds support for
> > this new type of controllers (internally called "GEM Series"), that
> > differ from other DAC960 V2 firmware controllers only in the register
> > offsets and removes support for all others.
> > 
> > This patch instead integrates support for these controllers into the
> > DAC960 driver.
> > 
> > Thanks to Anders Norrbring for pointing me to the idac320 driver and
> > testing this patch.
> > 
> > No Signed-Off: line because all code is either copy & pasted from IBM's
> > idac320 driver or support for other controllers in the 2.6 DAC960
> > driver.

I think a S-O-B is still appropriate in this case.  You worked on it, so..

> > Note: the really odd formating matches the rest of the DAC960 driver.

Yeah, maybe a big Lindenting is called for.  Although that would make
patches such as this one a heck of a lot harder.