From: Andrea Arcangeli <andrea@suse.de>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Andi Kleen <ak@suse.de>, Andrew Morton <akpm@osdl.org>,
linux-kernel@vger.kernel.org
Subject: Re: avoid infinite loop in x86_64 interrupt return
Date: Wed, 4 May 2005 15:31:29 +0200 [thread overview]
Message-ID: <20050504133129.GD3899@opteron.random> (raw)
In-Reply-To: <200505041100.33099.rjw@sisk.pl>
On Wed, May 04, 2005 at 11:00:32AM +0200, Rafael J. Wysocki wrote:
> You also need to add two missing clis. Please have a look at the attached
> patch from Andi.
Those two clis seems unrelated, so I don't see why I should mix them in
the same patch. I couldn't trigger the other problems, only the one with
rdi corruption.
Note that those clis seems superflous, cli is only needed before swapgs,
so adding cli before swapgs in retint_swapgs sounds a better idea than
to keep irq off for a longer time for no apparent good reason. But I've
no real idea why those cli are needed so I guess I must be missing
something. there's no commentary attached to your patch that can exlain
why the cli are needed _way_ before calling swapgs.
next prev parent reply other threads:[~2005-05-04 13:31 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-04 5:01 avoid infinite loop in x86_64 interrupt return Andrea Arcangeli
2005-05-04 9:00 ` Rafael J. Wysocki
2005-05-04 13:31 ` Andrea Arcangeli [this message]
2005-05-04 18:21 ` Andi Kleen
2005-05-04 18:32 ` Andrea Arcangeli
2005-05-04 13:22 ` Andi Kleen
2005-05-04 13:32 ` Andrea Arcangeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050504133129.GD3899@opteron.random \
--to=andrea@suse.de \
--cc=ak@suse.de \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@sisk.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox