From: Alexey Dobriyan <adobriyan@mail.ru>
To: "Hyok S. Choi" <hyok.choi@samsung.com>
Cc: linux-arm-kernel@lists.arm.linux.org.uk,
linux-kernel@vger.kernel.org, uclinux-dev@uclinux.org
Subject: Re: [PATCH 7/17] ARMNOMMU - platform patch for atmel
Date: Sat, 7 May 2005 16:23:12 +0000 [thread overview]
Message-ID: <200505071623.13143.adobriyan@mail.ru> (raw)
In-Reply-To: <0IG400GQR1G2NY@mmp2.samsung.com>
On Saturday 07 May 2005 08:10, Hyok S. Choi wrote:
> --- linux-2.6.12-rc3-mm3/arch/arm/mach-atmel/Makefile
> +++ linux-2.6.12-rc3-mm3-hsc0/arch/arm/mach-atmel/Makefile
> +#
> +# Makefile for the linux kernel.
> +#
> +# Object file lists.
Useless comments.
> +obj-y += arch.o irq.o time.o
> --- linux-2.6.12-rc3-mm3/arch/arm/mach-atmel/arch.c
> +++ linux-2.6.12-rc3-mm3-hsc0/arch/arm/mach-atmel/arch.c
[21 #include directives snipped]
> +extern void atmel_time_init(void);
> +extern unsigned long atmel_gettimeoffset(void);
> +
> +extern void __init atmel_init_irq(void);
> +
> +extern struct sys_timer atmel_timer;
> +
> +MACHINE_START(ATMEL, "ATMEL EB01")
> + MAINTAINER("Hyok S. Choi <hyok.choi@samsung.com>")
> + INITIRQ(atmel_init_irq)
> + .timer = &atmel_timer,
> +MACHINE_END
So, all you need is:
include/linux/init.h
include/asm-arm/mach/time.h
include/asm-arm/mach/arch.h
And maybe one or two more.
> --- linux-2.6.12-rc3-mm3/arch/arm/mach-atmel/irq.c
> +++ linux-2.6.12-rc3-mm3-hsc0/arch/arm/mach-atmel/irq.c
> +static unsigned char eb01_irq_prtable[32] = {
Should it be ...[NR_IRQS] ?
> + 7 << 5, /* FIQ */
> + 0 << 5, /* SWIRQ */
> + 0 << 5, /* US0IRQ */
> + 0 << 5, /* US1IRQ */
> + 2 << 5, /* TC0IRQ */
> + 2 << 5, /* TC1IRQ */
> + 2 << 5, /* TC2IRQ */
> + 0 << 5, /* WDIRQ */
> + 0 << 5, /* PIOAIRQ */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 0 << 5, /* reserved */
> + 1 << 5, /* IRQ0 */
> + 0 << 5, /* IRQ1 */
> + 0 << 5, /* IRQ2 */
> +};
You are doing "eb01_irq_prtable[irq] >> 5" always.
> + for ( irq = 0 ; irq < 32 ; irq++ )
> + {
> + __raw_writel(irq, AIC_EOICR);
> + }
> + for ( irq = 0 ; irq < 32 ; irq++ )
> + {
> + __raw_writel((eb01_irq_prtable[irq] >> 5) | eb01_irq_type[irq],
> + AIC_SMR(irq));
> + }
Use consistent style for "for" statements and brackets. Like in the next line.
> + for (irq = 0; irq < NR_IRQS; irq++) {
Please, remove trailing whitespace from this patch. There is quite a few of
it.
next prev parent reply other threads:[~2005-05-07 12:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-07 8:10 [PATCH 7/17] ARMNOMMU - platform patch for atmel Hyok S. Choi
2005-05-07 16:23 ` Alexey Dobriyan [this message]
2005-05-08 3:12 ` [PATCH 7/17][REFINED] " Hyok S. Choi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505071623.13143.adobriyan@mail.ru \
--to=adobriyan@mail.ru \
--cc=hyok.choi@samsung.com \
--cc=linux-arm-kernel@lists.arm.linux.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=uclinux-dev@uclinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox