Re: [1/1] connector/CBUS: new messaging subsystem. Revision number next.

Dmitry Torokhov
2005-04-26T17:34:50Z

On 4/26/05, Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote:
>
> --- orig/drivers/connector/connector.c
> +++ mod/drivers/connector/connector.c
> @@ -151,8 +151,8 @@
> __cbq->ddata = data;
> __cbq->destruct_data = destruct_data;
>
> - queue_work(dev->cbdev->cn_queue, &__cbq->work);
> - found = 1;
> + if (queue_work(dev->cbdev->cn_queue, &__cbq->work))
> + found = 1;
> break;

What does it help exactly? By the time you checked result of
queue_work you have already corrupted work structure wuth the new data
(and probably destructor).

Also, where is the rest of the code? Should we notify caller that
cn_netlink_send has dropped the message? And how do we do that?

--
Dmitry