The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@osdl.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: ak@suse.de, linux-kernel@vger.kernel.org, axboe@suse.de,
	alexn@dsv.su.se, lnxluv@yahoo.com,
	Christoph Lameter <christoph@lameter.com>
Subject: Re: [BUG][Resend] 2.6.12-rc3-mm3: Kernel BUG at "mm/slab.c":1219 [update]
Date: Tue, 10 May 2005 11:22:24 -0700	[thread overview]
Message-ID: <20050510112224.761f5d68.akpm@osdl.org> (raw)
In-Reply-To: <200505101443.31229.rjw@sisk.pl>

"Rafael J. Wysocki" <rjw@sisk.pl> wrote:
>
> > Clearly init_bio() is not passing in a NULL `name' parameter.  Maybe the
>  > backtrace is screwed due to dopey gcc autoinlining and the bad caller is
>  > really biovec_init_slabs().  Try removing the
>  > __cacheline_aligned_mostly_readonly from the declaration of bvec_slabs[].
> 
>  Heh, it boots without the __cacheline_aligned_mostly_readonly (ie the BUG is
>  only triggered if the __cacheline_aligned_mostly_readonly is present in the
>  declaration of bvec_slabs[]).  I've double-checked it.  Interesting ... ;-)

oops.

+#ifdef CONFIG_X86
+#define __cacheline_aligned_mostly_readonly		\
+  __attribute__((__aligned__(SMP_CACHE_BYTES),		\
+		 __section__(".data.mostly_readonly")))
+#else
+#define __cacheline_aligned_mostly_readonly __cacheline_aligned
+#endif

So on x86_64 we're putting __cacheline_aligned_mostly_readonly stuff into a
section which is not implemented anywhere.  I'm rather surprised that the
kernel linked at all.  But I'm more surprised that it mysteriously oopsed.

Oh well, I'll change that to CONFIG_X86 && !CONFIG_X86_64, thanks.

Or maybe Christoph wants to rustle up the x86_64 patch?  We really should
patch all architectures if we're going to do this thing.

  reply	other threads:[~2005-05-10 18:23 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-09 20:39 [BUG][Resend] 2.6.12-rc3-mm3: Kernel BUG at "mm/slab.c":1219 Rafael J. Wysocki
2005-05-09 20:52 ` Andi Kleen
2005-05-10  6:18   ` Jens Axboe
2005-05-10  8:28     ` Alexander Nyberg
2005-05-10  9:02       ` Jens Axboe
2005-05-10 10:55     ` Andi Kleen
2005-05-09 21:54 ` Andrew Morton
2005-05-10 11:49   ` Rafael J. Wysocki
2005-05-10 12:43   ` [BUG][Resend] 2.6.12-rc3-mm3: Kernel BUG at "mm/slab.c":1219 [update] Rafael J. Wysocki
2005-05-10 18:22     ` Andrew Morton [this message]
2005-05-10 21:11       ` Andi Kleen
2005-05-10 21:44         ` Christoph Lameter
2005-05-10 21:49           ` Andi Kleen
2005-05-10 22:01             ` Christoph Lameter
2005-05-10 22:15               ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050510112224.761f5d68.akpm@osdl.org \
    --to=akpm@osdl.org \
    --cc=ak@suse.de \
    --cc=alexn@dsv.su.se \
    --cc=axboe@suse.de \
    --cc=christoph@lameter.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lnxluv@yahoo.com \
    --cc=rjw@sisk.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox