From: Markus Klotzbuecher <mk@creamnet.de>
To: Eric Lammerts <eric@lammerts.org>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [ANNOUNCE] mini_fo-0.6.0 overlay file system
Date: Tue, 10 May 2005 19:01:28 +0200 [thread overview]
Message-ID: <20050510170127.GA13280@mary> (raw)
In-Reply-To: <42804FA9.3020307@lammerts.org>
Hi Eric,
Thank you for the feedback.
On Tue, May 10, 2005 at 02:07:37AM -0400, Eric Lammerts wrote:
> Some remarks:
> Some functions return -ENOTSUPP on error, which makes "ls -l" complain
> loudly when getxattr() fails. This should be -EOPNOTSUPP.
You're right. Fixed in attached patch.
> The module taints the kernel because of MODULE_LICENSE("LGPL").
> Since all your copyright statements say it's GPL software, better change
> this to "GPL".
It seems to be ok to change this. Patch corrects this too.
Cheers
Markus
diff -Nru mini_fo.ORIG/inode.c mini_fo/inode.c
--- mini_fo.ORIG/inode.c 2005-05-06 23:59:08.000000000 +0200
+++ mini_fo/inode.c 2005-05-10 18:09:47.000000000 +0200
@@ -1259,7 +1259,7 @@
STATIC int
mini_fo_getxattr(struct dentry *dentry, const char *name, void *value, size_t size) {
struct dentry *hidden_dentry = NULL;
- int err = -ENOTSUPP;
+ int err = -EOPNOTSUPP;
/* Define these anyway so we don't need as much ifdef'ed code. */
char *encoded_name = NULL;
char *encoded_value = NULL;
@@ -1304,7 +1304,7 @@
{
struct dentry *hidden_dentry = NULL;
- int err = -ENOTSUPP;
+ int err = -EOPNOTSUPP;
/* Define these anyway, so we don't have as much ifdef'ed code. */
char *encoded_value = NULL;
@@ -1340,7 +1340,7 @@
STATIC int
mini_fo_removexattr(struct dentry *dentry, const char *name) {
struct dentry *hidden_dentry = NULL;
- int err = -ENOTSUPP;
+ int err = -EOPNOTSUPP;
char *encoded_name;
check_mini_fo_dentry(dentry);
@@ -1372,7 +1372,7 @@
STATIC int
mini_fo_listxattr(struct dentry *dentry, char *list, size_t size) {
struct dentry *hidden_dentry = NULL;
- int err = -ENOTSUPP;
+ int err = -EOPNOTSUPP;
char *encoded_list = NULL;
check_mini_fo_dentry(dentry);
diff -Nru mini_fo.ORIG/main.c mini_fo/main.c
--- mini_fo.ORIG/main.c 2005-05-06 23:59:08.000000000 +0200
+++ mini_fo/main.c 2005-05-10 17:54:13.000000000 +0200
@@ -405,7 +405,7 @@
MODULE_AUTHOR("Erez Zadok <ezk@cs.sunysb.edu>");
MODULE_DESCRIPTION("FiST-generated mini_fo filesystem");
-MODULE_LICENSE("LGPL");
+MODULE_LICENSE("GPL");
/* MODULE_PARM(fist_debug_var, "i"); */
/* MODULE_PARM_DESC(fist_debug_var, "Debug level"); */
next prev parent reply other threads:[~2005-05-10 16:59 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-09 18:40 [ANNOUNCE] mini_fo-0.6.0 overlay file system Markus Klotzbuecher
2005-05-10 6:07 ` Eric Lammerts
2005-05-10 15:29 ` Lee Revell
2005-05-10 15:42 ` Arjan van de Ven
2005-05-10 17:01 ` Markus Klotzbuecher [this message]
2005-05-12 12:18 ` Jörn Engel
2005-05-12 16:44 ` Markus Klotzbuecher
2005-05-13 3:18 ` Kyle Moffett
2005-05-13 8:01 ` Jörn Engel
2005-05-13 11:26 ` Kyle Moffett
2005-05-13 12:24 ` Jörn Engel
2005-05-13 20:57 ` Kyle Moffett
2005-05-13 12:49 ` Jan Blunck
2005-05-13 20:18 ` Markus Klotzbuecher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050510170127.GA13280@mary \
--to=mk@creamnet.de \
--cc=eric@lammerts.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox