public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [patch 1/6] uml: remove elf.h [ compile-fix, for 2.6.12 ]
@ 2005-05-09 22:45 blaisorblade
  2005-05-10  1:34 ` Andrew Morton
  0 siblings, 1 reply; 7+ messages in thread
From: blaisorblade @ 2005-05-09 22:45 UTC (permalink / raw)
  To: akpm; +Cc: jdike, linux-kernel, user-mode-linux-devel, blaisorblade


Actually remove elf.h in the tree. The previous patch, due to a quilt
bug/misuse, left it in the tree as a 0-length file, preventing the build to
see it as missing and to generate a symlink in its place.

Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
---

  |    0 
 1 files changed

diff -L include/asm-um/elf.h -puN include/asm-um/elf.h~uml-remove-elf-h /dev/null
_

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [patch 1/6] uml: remove elf.h [ compile-fix, for 2.6.12 ]
  2005-05-09 22:45 [patch 1/6] uml: remove elf.h [ compile-fix, for 2.6.12 ] blaisorblade
@ 2005-05-10  1:34 ` Andrew Morton
  2005-05-10 10:16   ` Blaisorblade
                     ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Andrew Morton @ 2005-05-10  1:34 UTC (permalink / raw)
  To: blaisorblade; +Cc: jdike, linux-kernel, user-mode-linux-devel, blaisorblade

blaisorblade@yahoo.it wrote:
>
> 
> Actually remove elf.h in the tree. The previous patch, due to a quilt
> bug/misuse, left it in the tree as a 0-length file, preventing the build to
> see it as missing and to generate a symlink in its place.
> 
> Signed-off-by: Paolo 'Blaisorblade' Giarrusso <blaisorblade@yahoo.it>
> ---
> 
>   |    0 
>  1 files changed
> 
> diff -L include/asm-um/elf.h -puN include/asm-um/elf.h~uml-remove-elf-h /dev/null

hmm, that's exciting.  How to tell diff and patch to remove a zero-length
file?

bix:/home/akpm> mkdir a b
bix:/home/akpm> touch a/a
bix:/home/akpm> diff -uNr a b
bix:/home/akpm> diff -u a b  
Only in a: a
bix:/home/akpm> diff -ur a b
Only in a: a
bix:/home/akpm> diff -uPr a b
Only in a: a

I'll just ask Linus to delete it ;)

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [patch 1/6] uml: remove elf.h [ compile-fix, for 2.6.12 ]
  2005-05-10  1:34 ` Andrew Morton
@ 2005-05-10 10:16   ` Blaisorblade
  2005-05-10 13:37   ` [uml-devel] " Henrik Nordstrom
  2005-05-10 18:06   ` Andrea Arcangeli
  2 siblings, 0 replies; 7+ messages in thread
From: Blaisorblade @ 2005-05-10 10:16 UTC (permalink / raw)
  To: Andrew Morton; +Cc: jdike, linux-kernel, user-mode-linux-devel

On Tuesday 10 May 2005 03:34, Andrew Morton wrote:
> blaisorblade@yahoo.it wrote:
> > Actually remove elf.h in the tree. The previous patch, due to a quilt
> > bug/misuse, left it in the tree as a 0-length file, preventing the build
> > to see it as missing and to generate a symlink in its place.

Ok, I was confused by the fact that with patch-scripts, which you use, it 
works, and thought it was patch to make it work.
-- 
Paolo Giarrusso, aka Blaisorblade
Skype user "PaoloGiarrusso"
Linux registered user n. 292729
http://www.user-mode-linux.org/~blaisorblade


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [uml-devel] Re: [patch 1/6] uml: remove elf.h [ compile-fix, for 2.6.12 ]
  2005-05-10  1:34 ` Andrew Morton
  2005-05-10 10:16   ` Blaisorblade
@ 2005-05-10 13:37   ` Henrik Nordstrom
  2005-05-10 20:40     ` Adrian Bunk
  2005-05-10 18:06   ` Andrea Arcangeli
  2 siblings, 1 reply; 7+ messages in thread
From: Henrik Nordstrom @ 2005-05-10 13:37 UTC (permalink / raw)
  To: Andrew Morton; +Cc: blaisorblade, jdike, linux-kernel, user-mode-linux-devel

On Mon, 9 May 2005, Andrew Morton wrote:

>> diff -L include/asm-um/elf.h -puN include/asm-um/elf.h~uml-remove-elf-h /dev/null
>
> hmm, that's exciting.  How to tell diff and patch to remove a zero-length
> file?

This has to be instructed by the patch.. If the new file is an empty file 
with timestamp of 1 Jan 1970 then it is supposed to be deleted.

The /dev/null trick only works well for adding files, not removing them.

Regards
Henrik

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [patch 1/6] uml: remove elf.h [ compile-fix, for 2.6.12 ]
  2005-05-10  1:34 ` Andrew Morton
  2005-05-10 10:16   ` Blaisorblade
  2005-05-10 13:37   ` [uml-devel] " Henrik Nordstrom
@ 2005-05-10 18:06   ` Andrea Arcangeli
  2 siblings, 0 replies; 7+ messages in thread
From: Andrea Arcangeli @ 2005-05-10 18:06 UTC (permalink / raw)
  To: Andrew Morton; +Cc: blaisorblade, jdike, linux-kernel, user-mode-linux-devel

On Mon, May 09, 2005 at 06:34:01PM -0700, Andrew Morton wrote:
> I'll just ask Linus to delete it ;)

make distclean should delete it too. I never worry about zero length
file, they'll be deleted eventually.

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [uml-devel] Re: [patch 1/6] uml: remove elf.h [ compile-fix, for 2.6.12 ]
  2005-05-10 13:37   ` [uml-devel] " Henrik Nordstrom
@ 2005-05-10 20:40     ` Adrian Bunk
  2005-05-10 20:54       ` Jesper Juhl
  0 siblings, 1 reply; 7+ messages in thread
From: Adrian Bunk @ 2005-05-10 20:40 UTC (permalink / raw)
  To: Henrik Nordstrom
  Cc: Andrew Morton, blaisorblade, jdike, linux-kernel,
	user-mode-linux-devel

On Tue, May 10, 2005 at 03:37:33PM +0200, Henrik Nordstrom wrote:
>...
> The /dev/null trick only works well for adding files, not removing them.

It works fine for removing files except when they have a zero length.

> Regards
> Henrik

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [uml-devel] Re: [patch 1/6] uml: remove elf.h [ compile-fix, for 2.6.12 ]
  2005-05-10 20:40     ` Adrian Bunk
@ 2005-05-10 20:54       ` Jesper Juhl
  0 siblings, 0 replies; 7+ messages in thread
From: Jesper Juhl @ 2005-05-10 20:54 UTC (permalink / raw)
  To: Adrian Bunk
  Cc: Henrik Nordstrom, Andrew Morton, blaisorblade, jdike,
	linux-kernel, user-mode-linux-devel

On Tue, 10 May 2005, Adrian Bunk wrote:

> On Tue, May 10, 2005 at 03:37:33PM +0200, Henrik Nordstrom wrote:
> >...
> > The /dev/null trick only works well for adding files, not removing them.
> 
> It works fine for removing files except when they have a zero length.
> 
Then a two-patch approach would seem to work as a hack. First patch just 
adds a blank line to the file making in non-zero length, second patch then 
uses the /dev/null trick to kill the file. A hack? Yes, certainly, but it 
sounds like it would work (actually, it does work, just tried it).


-- 
Jesper Juhl


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2005-05-10 20:54 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-09 22:45 [patch 1/6] uml: remove elf.h [ compile-fix, for 2.6.12 ] blaisorblade
2005-05-10  1:34 ` Andrew Morton
2005-05-10 10:16   ` Blaisorblade
2005-05-10 13:37   ` [uml-devel] " Henrik Nordstrom
2005-05-10 20:40     ` Adrian Bunk
2005-05-10 20:54       ` Jesper Juhl
2005-05-10 18:06   ` Andrea Arcangeli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox