From: Greg KH <greg@kroah.com>
To: Yani Ioannou <yani.ioannou@gmail.com>,
Dmitry Torokhov <dtor_core@ameritech.net>,
Jean Delvare <khali@linux-fr.org>,
LM Sensors <sensors@stimpy.netroedge.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.12-rc4 1/3] dynamic sysfs callbacks
Date: Wed, 11 May 2005 00:05:34 -0700 [thread overview]
Message-ID: <20050511070534.GA10194@kroah.com> (raw)
In-Reply-To: <20050511075100.A20000@flint.arm.linux.org.uk>
On Wed, May 11, 2005 at 07:51:00AM +0100, Russell King wrote:
> On Tue, May 10, 2005 at 03:16:15PM -0700, Greg KH wrote:
> > +#define __ATTR(_name,_mode,_show,_store) { \
> > + .attr = { \
> > + .name = __stringify(_name), \
> > + .mode = _mode, \
> > + .private = NULL, \
>
> We don't specifically initialise elements to NULL or zero. Is this a
> change of policy?
Doh, no, it isn't, you are correct. I've updated the patch, removing
the changes to the __ATTR() and other macro that I modified.
Thanks for catching this.
greg k-h
prev parent reply other threads:[~2005-05-11 7:05 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-07 13:21 [PATCH 2.6.12-rc4 1/3] dynamic sysfs callbacks Yani Ioannou
2005-05-10 22:16 ` Greg KH
2005-05-11 0:13 ` Yani Ioannou
2005-05-11 0:59 ` Yani Ioannou
2005-05-11 2:32 ` Greg KH
2005-05-11 6:51 ` Russell King
2005-05-11 7:05 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050511070534.GA10194@kroah.com \
--to=greg@kroah.com \
--cc=dtor_core@ameritech.net \
--cc=khali@linux-fr.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
--cc=yani.ioannou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox