public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Tom Duffy <tduffy@sun.com>
Cc: Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org, Jesper Juhl <juhl-lkml@dif.dk>
Subject: Re: [PATCH] kernel/module.c has something to hide. (whitespace cleanup)
Date: Wed, 11 May 2005 11:04:36 +0200	[thread overview]
Message-ID: <20050511090436.GL3590@stusta.de> (raw)
In-Reply-To: <1115773263.3169.5.camel@duffman>

On Tue, May 10, 2005 at 06:01:03PM -0700, Tom Duffy wrote:
> 
> Solaris build makes sure files passes a "lint" test during the build and
> nothing can be checked in until such a test can pass.
> 
> Would it make sense to add such a test during kernel compile for Linux?
> Something that could be turned off if somebody needed really fast
> builds.  This would check for things like whitespace violations and
> other things that violate CodingStyle.
> 
> People tend to fix things quick if they break the build.

This works _after_ the kernel has been cleaned up.

And then there's the issue that some code (e.g. ACPI or XFS) is shared 
between Linux and other OS's, and therefore a limited amount of 
divergence from usual kernel coding style is allowed in such code.

> -tduffy

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2005-05-11  9:09 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-10 23:02 [PATCH] kernel/module.c has something to hide. (whitespace cleanup) Jesper Juhl
2005-05-10 23:16 ` Andrew Morton
2005-05-10 23:30   ` Jesper Juhl
     [not found]   ` <20050510.161907.116353193.davem@davemloft.net>
2005-05-11  0:02     ` Andrew Morton
2005-05-11  0:11       ` Jesper Juhl
2005-05-11  0:23         ` Andrew Morton
     [not found]       ` <20050510.170946.10291902.davem@davemloft.net>
2005-05-11  0:28         ` Jesper Juhl
2005-05-11  0:29           ` Andrew Morton
2005-05-11  0:38             ` Jesper Juhl
2005-05-11 11:07               ` Paulo Marques
2005-05-11 22:56                 ` Adrian Bunk
2005-05-12 12:16                   ` Paulo Marques
2005-05-12 13:36                     ` Paulo Marques
2005-05-12 17:26                       ` Jesper Juhl
2005-05-12 18:06                         ` Hugh Dickins
2005-05-11  1:01             ` Tom Duffy
2005-05-11  9:04               ` Adrian Bunk [this message]
     [not found] <42Mbg-Tq-25@gated-at.bofh.it>
     [not found] ` <42MXA-1zI-3@gated-at.bofh.it>
     [not found]   ` <42MXA-1zI-1@gated-at.bofh.it>
     [not found]     ` <42Nh3-1M8-17@gated-at.bofh.it>
     [not found]       ` <42Nh3-1M8-15@gated-at.bofh.it>
2005-05-11 23:47         ` Bodo Eggert <harvested.in.lkml@posting.7eggert.dyndns.org>
2005-05-12  4:00           ` Nick Piggin
2005-05-12  5:16             ` Bodo Eggert
2005-05-12  8:41           ` Jesper Juhl
2005-05-12  8:47             ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050511090436.GL3590@stusta.de \
    --to=bunk@stusta.de \
    --cc=akpm@osdl.org \
    --cc=juhl-lkml@dif.dk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tduffy@sun.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox