From: Christoph Hellwig <hch@infradead.org>
To: cotte@freenet.de
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
schwidefsky@de.ibm.com, akpm@osdl.org
Subject: Re: [RFC/PATCH 2/5] mm/fs: add execute in place support
Date: Wed, 11 May 2005 16:09:24 +0100 [thread overview]
Message-ID: <20050511150924.GA29976@infradead.org> (raw)
In-Reply-To: <428216F7.30303@de.ibm.com>
On Wed, May 11, 2005 at 04:30:15PM +0200, Carsten Otte wrote:
> [RFC/PATCH 2/5] mm/fs: add execute in place support
> This patch is the biggest chunk in the patchset. It adds a new address
> space operation called get_xip_page, which works similar to
> readpage/writepage but returns a reference to a struct page for the
> on-disk data for the given page. The page is supposed to be up-to-date.
> In mm/filemap.c, all generic implementations of file operations are
> extended to work with the new address space operation if provided.
This is a lot of code for a very special case.
Could you try to put all the xip code into a separate file, e.g. mm/xip.c
that's only built when CONFIG_XIP is set? It would probably require
duplicating a little more code if you want clean interfaces, e.g. probably
a separate set of generic operations.
next prev parent reply other threads:[~2005-05-11 15:09 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 14:30 [RFC/PATCH 2/5] mm/fs: add execute in place support Carsten Otte
2005-05-11 15:09 ` Christoph Hellwig [this message]
2005-05-11 15:33 ` Carsten Otte
2005-05-11 15:47 ` Badari Pulavarty
2005-05-11 16:19 ` Carsten Otte
2005-05-11 17:31 ` Arnd Bergmann
2005-05-11 17:47 ` Carsten Otte
2005-05-11 17:50 ` Matthew Wilcox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050511150924.GA29976@infradead.org \
--to=hch@infradead.org \
--cc=akpm@osdl.org \
--cc=cotte@freenet.de \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox