From: Greg KH <greg@kroah.com>
To: Yani Ioannou <yani.ioannou@gmail.com>
Cc: LM Sensors <sensors@stimpy.netroedge.com>,
linux-kernel@vger.kernel.org,
Justin Thiessen <jthiessen@penguincomputing.com>
Subject: Re: [PATCH 2.6.12-rc4 3/3] (dynamic sysfs callbacks) device_attribute
Date: Wed, 11 May 2005 10:06:00 -0700 [thread overview]
Message-ID: <20050511170600.GD15398@kroah.com> (raw)
In-Reply-To: <2538186705051100583c6b1ffb@mail.gmail.com>
On Wed, May 11, 2005 at 03:58:35AM -0400, Yani Ioannou wrote:
> Hi,
>
> This patch presents as an example one possible way to use the dynamic
> callbacks to clean up one of the i2c chip drivers, adm1026 (for more
> information please see
> http://archives.andrew.net.au/lm-sensors/msg31310.html).
>
> The first patch defines a new macros like DEVICE_ATTR that also sets
> the attribute private data (Greg whats your opinion on defining a
> separate set of macros for this v.s. rolling it into one macro?).
We should make a __ATTR macro instead, right?
> The second patch changes adm1026 to pass the sensor index/number via
> the private data pointer. I can't test this patch (so you won't want
> to apply this) but I'm CCing it to the adm1026 maintainer.
One patch per email please...
thanks,
greg k-h
next prev parent reply other threads:[~2005-05-11 17:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-11 7:58 [PATCH 2.6.12-rc4 3/3] (dynamic sysfs callbacks) device_attribute Yani Ioannou
2005-05-11 17:06 ` Greg KH [this message]
2005-05-11 19:57 ` Yani Ioannou
2005-05-11 20:28 ` Greg KH
2005-05-11 17:07 ` Greg KH
2005-05-11 20:10 ` [PATCH 2.6.12-rc4] (dynamic sysfs callbacks) adm1026 (2nd try) Yani Ioannou
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050511170600.GD15398@kroah.com \
--to=greg@kroah.com \
--cc=jthiessen@penguincomputing.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sensors@stimpy.netroedge.com \
--cc=yani.ioannou@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox