From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S261443AbVELLaD (ORCPT ); Thu, 12 May 2005 07:30:03 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S261461AbVELLaD (ORCPT ); Thu, 12 May 2005 07:30:03 -0400 Received: from ozlabs.org ([203.10.76.45]:52367 "EHLO ozlabs.org") by vger.kernel.org with ESMTP id S261443AbVELL37 (ORCPT ); Thu, 12 May 2005 07:29:59 -0400 Date: Thu, 12 May 2005 21:28:57 +1000 From: David Gibson To: Michael Ellerman Cc: Andrew Morton , Jeff Garzik , netdev@oss.sgi.com, linux-kernel@vger.kernel.org, PPC64-dev Subject: Re: [PATCH 4/4] iseries_veth: Cleanup skbs to prevent unregister_netdevice() hanging Message-ID: <20050512112857.GC32694@localhost.localdomain> Mail-Followup-To: David Gibson , Michael Ellerman , Andrew Morton , Jeff Garzik , netdev@oss.sgi.com, linux-kernel@vger.kernel.org, PPC64-dev References: <200505121809.45419.michael@ellerman.id.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <200505121809.45419.michael@ellerman.id.au> User-Agent: Mutt/1.5.6+20040907i Sender: linux-kernel-owner@vger.kernel.org X-Mailing-List: linux-kernel@vger.kernel.org On Thu, May 12, 2005 at 06:09:45PM +1000, Michael Ellerman wrote: > Hi Andrew, Jeff, > > The iseries_veth driver is badly behaved in that it will keep TX packets > hanging around forever if they're not ACK'ed and the queue never fills up. > > This causes the unregister_netdevice code to wait forever when we try to take > the device down, because there's still skbs around with references to our > struct net_device. > > There's already code to cleanup any un-ACK'ed packets in veth_stop_connection() > but it's being called after we unregister the net_device, which is too late. > > The fix is to rearrange the module exit function so that we cleanup any > outstanding skbs and then unregister the driver. > > Signed-off-by: Michael Ellerman Nice catch. Acked-by: David Gibson -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/people/dgibson