From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Andy Whitcroft <apw@shadowen.org>
Cc: linux-kernel@vger.kernel.org, Dave Hansen <haveblue@us.ibm.com>,
Martin Bligh <mbligh@aracnet.com>
Subject: [-mm patch] mm.h: fix page_zone compile error
Date: Thu, 12 May 2005 23:42:58 +0200 [thread overview]
Message-ID: <20050512214258.GC3603@stusta.de> (raw)
In-Reply-To: <20050512033100.017958f6.akpm@osdl.org>
On Thu, May 12, 2005 at 03:31:00AM -0700, Andrew Morton wrote:
>...
> Changes since 2.6.12-rc3-mm3:
>...
> +sparsemem-memory-model.patch
>...
> More sparsemem stuff
>...
This causes the following compile error with gcc 3.4 on i386:
<-- snip -->
...
CC mm/hugetlb.o
mm/hugetlb.c: In function `enqueue_huge_page':
include/linux/mm.h:500: sorry, unimplemented: inlining failed in call to
'page_zone': function not considered for inlining
mm/hugetlb.c:486: sorry, unimplemented: called from here
make[1]: *** [mm/hugetlb.o] Error 1
make: *** [mm] Error 2
<-- snip -->
This patch fixes this compile error.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
include/linux/mm.h | 20 ++++++++++----------
1 files changed, 10 insertions(+), 10 deletions(-)
--- linux-2.6.12-rc4-mm1-full/include/linux/mm.h.old 2005-05-12 22:54:04.000000000 +0200
+++ linux-2.6.12-rc4-mm1-full/include/linux/mm.h 2005-05-12 22:54:38.000000000 +0200
@@ -480,7 +480,16 @@
{
return (page->flags >> ZONES_PGSHIFT) & ZONES_MASK;
}
-static inline struct zone *page_zone(struct page *page);
+
+struct zone;
+extern struct zone *zone_table[];
+
+static inline struct zone *page_zone(struct page *page)
+{
+ return zone_table[(page->flags >> ZONETABLE_PGSHIFT) &
+ ZONETABLE_MASK];
+}
+
static inline unsigned long page_to_nid(struct page *page)
{
if (FLAGS_HAS_NODE)
@@ -493,15 +502,6 @@
return (page->flags >> SECTIONS_PGSHIFT) & SECTIONS_MASK;
}
-struct zone;
-extern struct zone *zone_table[];
-
-static inline struct zone *page_zone(struct page *page)
-{
- return zone_table[(page->flags >> ZONETABLE_PGSHIFT) &
- ZONETABLE_MASK];
-}
-
static inline void set_page_zone(struct page *page, unsigned long zone)
{
page->flags &= ~(ZONES_MASK << ZONES_PGSHIFT);
next prev parent reply other threads:[~2005-05-12 21:46 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-12 10:31 2.6.12-rc4-mm1 Andrew Morton
2005-05-12 12:21 ` 2.6.12-rc4-mm1, build results compared to 2.6.12-rc3-mm3 Jan Dittmer
2005-05-13 6:19 ` Maneesh Soni
2005-05-12 12:39 ` 2.6.12-rc4-mm1 Reuben Farrelly
2005-05-12 15:09 ` 2.6.12-rc4-mm1 Andrew Morton
2005-05-14 21:19 ` 2.6.12-rc4-mm1 Andrew James Wade
2005-05-12 12:58 ` kobject_register failed for intelfb (-EACCES) (Re: 2.6.12-rc4-mm1) Alexey Dobriyan
2005-05-12 15:43 ` Greg KH
2005-05-12 15:59 ` Andrew Morton
2005-05-12 16:04 ` Greg KH
2005-05-12 16:20 ` Alexey Dobriyan
2005-05-12 18:14 ` [PATCH -mm] Print KBD and AUX irqs correctly Alexey Dobriyan
2005-05-12 21:42 ` Adrian Bunk [this message]
2005-05-12 22:09 ` [-mm patch] mm.h: fix page_zone compile error Dave Hansen
2005-05-12 22:26 ` Adrian Bunk
2005-05-13 13:26 ` Andy Whitcroft
2005-05-12 21:54 ` 2.6.12-rc4-mm1 Greg KH
2005-05-13 0:47 ` [-mm patch] drivers/cpufreq/cpufreq_conservative.c: make cpufreq_gov_dbs static Adrian Bunk
2005-05-13 7:24 ` 2.6.12-rc4-mm1 Dave Airlie
2005-05-13 7:25 ` 2.6.12-rc4-mm1 Dave Airlie
2005-05-13 14:53 ` 2.6.12-rc4-mm1 steve
2005-05-13 18:12 ` [-mm patch] kprobes: arch_supports_kretprobes cleanup Frederik Deweerdt
2005-05-13 19:40 ` 2.6.12-rc4-mm1 Johannes Stezenbach
2005-05-14 11:27 ` 2.6.12-rc4-mm1 Richard Purdie
2005-05-16 11:27 ` 2.6.12-rc4-mm2 Richard Purdie
2005-05-15 1:20 ` 2.6.12-rc4-mm1 William Lee Irwin III
2005-05-15 1:30 ` 2.6.12-rc4-mm1 Andrew Morton
2005-05-15 9:44 ` 2.6.12-rc4-mm1 Jesper Juhl
2005-05-15 9:54 ` 2.6.12-rc4-mm1 Andrew Morton
2005-05-15 9:43 ` 2.6.12-rc4-mm1: drivers/usb/gadget/ether.c compile error Adrian Bunk
2005-05-16 15:26 ` David Brownell
2005-05-15 11:32 ` [-mm patch] arch/i386/Kconfig: SELECT_MEMORY_MODEL -> ARCH_SELECT_MEMORY_MODEL Adrian Bunk
2005-05-15 18:24 ` Dave Hansen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050512214258.GC3603@stusta.de \
--to=bunk@stusta.de \
--cc=akpm@osdl.org \
--cc=apw@shadowen.org \
--cc=haveblue@us.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@aracnet.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox