Re: [Lse-tech] Re: [PATCH] cpusets+hotplug+preepmt broken

Paul Jackson
2005-05-14T17:58:18Z

Srivatsa wrote:
> We don't bother about arch'es which dont support CPU Hotplug.
> ...
> Apart from being buggy on this count (that they don't lock_cpu_hotplug
> and/or don't check return value), they will also be buggy if ...

Ok. That makes sense.

Though it is a bit worrisome.

One of the two key ways to document something is to have all existing
code examples doing it the right way. Then someone adding a new
architecture, or adding hotplug to an existing architecture, will tend
to do the right thing, simply by doing what others have done.

Here we seem to have some cases where the "normal" ways to code some
things are broken for hotplug. But most of the arch's still have the
broken code patterns.

The other way to document something is with comments and Doc files.

It would seem that hotplug still has opportunities for improvement,
on both fronts.

Good luck ;).

--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@engr.sgi.com> 1.650.933.1373, 1.925.600.0401