From: Chris Mason <mason@suse.com>
To: Christoph Hellwig <hch@lst.de>
Cc: axboe@suse.de, linux-kernel@vger.kernel.org
Subject: Re: finding out whether a device supports ordered writes ahead of time
Date: Mon, 16 May 2005 08:12:13 -0400 [thread overview]
Message-ID: <200505160812.15362.mason@suse.com> (raw)
In-Reply-To: <20050516112722.GA9736@lst.de>
On Monday 16 May 2005 07:27, Christoph Hellwig wrote:
> Currently ext3 and reiserfs submit bios with BIO_RW_BARRIER and when the
> device doesn't support it it returns EOPNOTUPP. This scheme doesn't
> work at all for XFS because our I/O submission path keeps around far too
> much state (XFS supports multi-page metadata buffers). From looking at
> the code it seems that we can assume such a submission will just work
> if q->ordered is not QUEUE_ORDERED_NONE. Is that a valid assumption?
> and if yes should we look directly at the queue or provide an assecor?
I think Jens currently has things set to trust the drive's advertisement of
the cache flush feature. But I don't think we've looked hard for drives that
advertise and then fail the barriers, it wouldn't surprise me if one existed.
What you could do is issue a barrier write during mount to test things. If
that works any failed barrier later could be considered an io error. Don't
use blkdev_issue_flush for this, since it will work on scsi drives that don't
support the BIO_RW_BARRIER.
-chris
prev parent reply other threads:[~2005-05-16 12:12 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-16 11:27 finding out whether a device supports ordered writes ahead of time Christoph Hellwig
2005-05-16 12:12 ` Chris Mason [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200505160812.15362.mason@suse.com \
--to=mason@suse.com \
--cc=axboe@suse.de \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox