From: Willy Tarreau <wtarreau@exosec.fr>
To: marcelo.tosatti@cyclades.com
Cc: linux-kernel@vger.kernel.org, David.Monniaux@ens.fr
Subject: Re: Linux 2.4.31-pre2
Date: Mon, 16 May 2005 10:32:34 +0200 [thread overview]
Message-ID: <20050516083234.GE11282@exosec.fr> (raw)
Hi Marcelo,
moxa does not compile anymore in 2.4.31-pre2, because a variable is used
before being declared. Since I fixed it on the fly in -hf, I thought that I
had reported it, but I don't find any trace of it, so I might have dreamed...
Here's the fix anyway.
Regards,
Willy
diff -urN linux-2.4.31-pre2/drivers/char/moxa.c linux-2.4.31-pre2-moxa-fix/drivers/char/moxa.c
--- linux-2.4.31-pre2/drivers/char/moxa.c 2005-05-16 10:26:12.000000000 +0200
+++ linux-2.4.31-pre2-moxa-fix/drivers/char/moxa.c 2005-05-16 10:26:29.000000000 +0200
@@ -294,6 +294,7 @@
static int moxa_get_serial_info(struct moxa_str *, struct serial_struct *);
static int moxa_set_serial_info(struct moxa_str *, struct serial_struct *);
static void MoxaSetFifo(int port, int enable);
+static unsigned long moxaIntPend[MAX_BOARDS];
#ifdef MODULE
int init_module(void)
@@ -1579,7 +1580,6 @@
static unsigned char moxaBuff[10240];
static unsigned long moxaIntNdx[MAX_BOARDS];
-static unsigned long moxaIntPend[MAX_BOARDS];
static unsigned long moxaIntTable[MAX_BOARDS];
static char moxaChkPort[MAX_PORTS];
static char moxaLineCtrl[MAX_PORTS];
next reply other threads:[~2005-05-16 8:36 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-16 8:32 Willy Tarreau [this message]
-- strict thread matches above, loose matches on Subject: below --
2005-05-12 14:24 Linux 2.4.31-pre2 Marcelo Tosatti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050516083234.GE11282@exosec.fr \
--to=wtarreau@exosec.fr \
--cc=David.Monniaux@ens.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=marcelo.tosatti@cyclades.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox