Re: NUMA aware slab allocator V3

Andrew Morton
2005-05-16T05:01:10Z

Christoph Lameter <clameter@engr.sgi.com> wrote:
>
> Here is Dave's patch again:
>
> =====================================================================
> I think I found the problem. Could you try the attached patch?
>
> As I said before FLATMEM is really referring to things like the
> mem_map[] or max_mapnr.
>
> CONFIG_NEED_MULTIPLE_NODES is what gets turned on for DISCONTIG or for
> NUMA. We'll slowly be removing all of the DISCONTIG cases, so
> eventually it will merge back to be one with NUMA.
>
> -- Dave
>
> --- clean/include/linux/numa.h.orig 2005-05-13 06:44:56.000000000
> -0700
> +++ clean/include/linux/numa.h 2005-05-13 06:52:05.000000000 -0700
> @@ -3,7 +3,7 @@
>
> #include <linux/config.h>
>
> -#ifndef CONFIG_FLATMEM
> +#ifdef CONFIG_NEED_MULTIPLE_NODES
> #include <asm/numnodes.h>
> #endif

Nope.

mm/slab.c:117:2: #error "Broken Configuration: CONFIG_NUMA not set but MAX_NUMNODES !=1 !!"