Re: [2.6 patch] lib/zlib*: possible cleanups

Andrew Morton
2005-06-21T01:11:26Z

Adrian Bunk <bunk@stusta.de> wrote:
>
> - #if 0 the following unused functions:
> - zlib_deflate/deflate.c: zlib_deflateSetDictionary
> - zlib_deflate/deflate.c: zlib_deflateParams
> - zlib_deflate/deflate.c: zlib_deflateCopy
> - zlib_inflate/infblock.c: zlib_inflate_set_dictionary
> - zlib_inflate/infblock.c: zlib_inflate_blocks_sync_point
> - zlib_inflate/inflate_sync.c: zlib_inflateSync
> - zlib_inflate/inflate_sync.c: zlib_inflateSyncPoint

OK...

> - remove the following unneeded EXPORT_SYMBOL's:
> - zlib_deflate/deflate_syms.c: zlib_deflateCopy
> - zlib_deflate/deflate_syms.c: zlib_deflateParams
> - zlib_inflate/inflate_syms.c: zlib_inflateSync
> - zlib_inflate/inflate_syms.c: zlib_inflateSyncPoint

Adrian, I've dropped just about every "remove the following unneeded
EXPORT_SYMBOL's" I've seen in the past several months. We've been round this
numerous times.

The question is, who are we screwing if we remove these?

It's difficult to answer, but we need to answer it.