Re: [2.6 patch] lib/zlib*: possible cleanups

Adrian Bunk
2005-06-21T13:44:13Z

On Mon, Jun 20, 2005 at 05:29:20PM -0700, Andrew Morton wrote:
> Adrian Bunk <bunk@stusta.de> wrote:
> >
> > - #if 0 the following unused functions:
> > - zlib_deflate/deflate.c: zlib_deflateSetDictionary
> > - zlib_deflate/deflate.c: zlib_deflateParams
> > - zlib_deflate/deflate.c: zlib_deflateCopy
> > - zlib_inflate/infblock.c: zlib_inflate_set_dictionary
> > - zlib_inflate/infblock.c: zlib_inflate_blocks_sync_point
> > - zlib_inflate/inflate_sync.c: zlib_inflateSync
> > - zlib_inflate/inflate_sync.c: zlib_inflateSyncPoint
>
> OK...
>
> > - remove the following unneeded EXPORT_SYMBOL's:
> > - zlib_deflate/deflate_syms.c: zlib_deflateCopy
> > - zlib_deflate/deflate_syms.c: zlib_deflateParams
> > - zlib_inflate/inflate_syms.c: zlib_inflateSync
> > - zlib_inflate/inflate_syms.c: zlib_inflateSyncPoint
>
> Adrian, I've dropped just about every "remove the following unneeded
> EXPORT_SYMBOL's" I've seen in the past several months. We've been round this
> numerous times.
>
> The question is, who are we screwing if we remove these?
>
> It's difficult to answer, but we need to answer it.

I'm sorry, but I'm not getting your point:

First, you ACK the part of my patch to #if 0 unused functions.

Then you complain that I've documented which EXPORT_SYMBOL's I have to
remove because I have #if 0'ed the functions they are exporting.

Will the patch be OK for you if I'll simply remove the part of the patch
description stating which of the #if 0'ed functions had been exported?

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed