Re: [2.6 patch] lib/zlib*: possible cleanups

Kjartan Maraas
2005-06-27T11:35:27Z

tir, 21,.06.2005 kl. 15.37 +0200, skrev Adrian Bunk:
> On Mon, Jun 20, 2005 at 05:29:20PM -0700, Andrew Morton wrote:
> > Adrian Bunk <bunk@stusta.de> wrote:
> > >
> > > - #if 0 the following unused functions:
> > > - zlib_deflate/deflate.c: zlib_deflateSetDictionary
> > > - zlib_deflate/deflate.c: zlib_deflateParams
> > > - zlib_deflate/deflate.c: zlib_deflateCopy
> > > - zlib_inflate/infblock.c: zlib_inflate_set_dictionary
> > > - zlib_inflate/infblock.c: zlib_inflate_blocks_sync_point
> > > - zlib_inflate/inflate_sync.c: zlib_inflateSync
> > > - zlib_inflate/inflate_sync.c: zlib_inflateSyncPoint
> >
> > OK...
> >
> > > - remove the following unneeded EXPORT_SYMBOL's:
> > > - zlib_deflate/deflate_syms.c: zlib_deflateCopy
> > > - zlib_deflate/deflate_syms.c: zlib_deflateParams
> > > - zlib_inflate/inflate_syms.c: zlib_inflateSync
> > > - zlib_inflate/inflate_syms.c: zlib_inflateSyncPoint
> >
> > Adrian, I've dropped just about every "remove the following unneeded
> > EXPORT_SYMBOL's" I've seen in the past several months. We've been round this
> > numerous times.
> >
> > The question is, who are we screwing if we remove these?
> >
> > It's difficult to answer, but we need to answer it.
>
>
> I'm sorry, but I'm not getting your point:
>
> First, you ACK the part of my patch to #if 0 unused functions.
>
> Then you complain that I've documented which EXPORT_SYMBOL's I have to
> remove because I have #if 0'ed the functions they are exporting.
>
The way I read it the "OK..." wasn't an agreement with the first hunk
but more of a prelude to the following comment. Or maybe I got it all
wrong too :-)

Cheers
Kjartan