public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Nishanth Aravamudan <nacc@us.ibm.com>
To: john stultz <johnstul@us.ibm.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
	Tim Schmielau <tim@physik3.uni-rostock.de>,
	George Anzinger <george@mvista.com>,
	albert@users.sourceforge.net,
	Ulrich Windl <ulrich.windl@rz.uni-regensburg.de>,
	Christoph Lameter <clameter@sgi.com>,
	Dominik Brodowski <linux@dominikbrodowski.de>,
	David Mosberger <davidm@hpl.hp.com>, Andi Kleen <ak@suse.de>,
	paulus@samba.org, schwidefsky@de.ibm.com,
	keith maanthey <kmannth@us.ibm.com>,
	Chris McDermott <lcm@us.ibm.com>, Max Asbock <masbock@us.ibm.com>,
	mahuja@us.ibm.com, Darren Hart <darren@dvhart.com>,
	"Darrick J. Wong" <djwong@us.ibm.com>,
	Anton Blanchard <anton@samba.org>,
	donf@us.ibm.com, mpm@selenic.com, benh@kernel.crashing.org
Subject: [RFC][PATCH 1/4] move arch-specific timeofday core to asm
Date: Tue, 17 May 2005 16:34:25 -0700	[thread overview]
Message-ID: <20050517233425.GF2735@us.ibm.com> (raw)
In-Reply-To: <20050517233300.GE2735@us.ibm.com>

On 17.05.2005 [16:33:00 -0700], Nishanth Aravamudan wrote:
> On 13.05.2005 [17:16:35 -0700], john stultz wrote:
> > All,
> > 	This patch implements the architecture independent portion of the new
> > time of day subsystem. For a brief description on the rework, see here:
> > http://lwn.net/Articles/120850/ (Many thanks to the LWN team for that
> > easy to understand writeup!)
> > 
> > 	I intend this to be the last RFC release and to submit this patch to
> > Andrew for for testing near the end of this month. So please, if you
> > have any complaints, suggestions, or blocking issues, let me know.
> 
> I have been working closely with John to re-work the soft-timer subsytem
> to use the new timeofday() subsystem. The following patches attempts to
> begin this process. I would greatly appreciate any comments.

Description: Updates the timeofday-rework to move arch-specific code
into asm headers files.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>

diff -urpN 2.6.12-rc4-tod-lkml/arch/i386/kernel/time.c 2.6.12-rc4-tod/arch/i386/kernel/time.c
--- 2.6.12-rc4-tod-lkml/arch/i386/kernel/time.c	2005-05-17 15:30:06.000000000 -0700
+++ 2.6.12-rc4-tod/arch/i386/kernel/time.c	2005-05-17 13:01:12.000000000 -0700
@@ -56,6 +56,7 @@
 #include <asm/uaccess.h>
 #include <asm/processor.h>
 #include <asm/timer.h>
+#include <asm/timeofday.h>
 
 #include "mach_time.h"
 
@@ -68,8 +69,6 @@
 
 #include "io_ports.h"
 
-#include <linux/timeofday.h>
-
 extern spinlock_t i8259A_lock;
 int pit_latch_buggy;              /* extern */
 
diff -urpN 2.6.12-rc4-tod-lkml/include/asm-generic/timeofday.h 2.6.12-rc4-tod/include/asm-generic/timeofday.h
--- 2.6.12-rc4-tod-lkml/include/asm-generic/timeofday.h	1969-12-31 16:00:00.000000000 -0800
+++ 2.6.12-rc4-tod/include/asm-generic/timeofday.h	2005-05-17 13:01:12.000000000 -0700
@@ -0,0 +1,26 @@
+/*  linux/include/asm-generic/timeofday.h
+ *
+ *  This file contains the asm-generic interface
+ *  to the arch specific calls used by the time of day subsystem
+ */
+#ifndef _ASM_GENERIC_TIMEOFDAY_H
+#define _ASM_GENERIC_TIMEOFDAY_H
+#include <linux/types.h>
+#include <linux/time.h>
+#include <linux/timex.h>
+#include <asm/div64.h>
+#ifdef CONFIG_NEWTOD
+
+/* Required externs */
+extern nsec_t read_persistent_clock(void);
+extern void sync_persistent_clock(struct timespec ts);
+
+#ifdef CONFIG_NEWTOD_VSYSCALL
+extern void arch_update_vsyscall_gtod(nsec_t wall_time, cycle_t offset_base,
+				struct timesource_t* timesource, int ntp_adj);
+#else
+#define arch_update_vsyscall_gtod(x,y,z,w) {}
+#endif /* CONFIG_NEWTOD_VSYSCALL */
+
+#endif /* CONFIG_NEWTOD */
+#endif
diff -urpN 2.6.12-rc4-tod-lkml/include/asm-i386/timeofday.h 2.6.12-rc4-tod/include/asm-i386/timeofday.h
--- 2.6.12-rc4-tod-lkml/include/asm-i386/timeofday.h	1969-12-31 16:00:00.000000000 -0800
+++ 2.6.12-rc4-tod/include/asm-i386/timeofday.h	2005-05-17 13:01:12.000000000 -0700
@@ -0,0 +1,4 @@
+#ifndef _ASM_I386_TIMEOFDAY_H
+#define _ASM_I386_TIMEOFDAY_H
+#include <asm-generic/timeofday.h>
+#endif
diff -urpN 2.6.12-rc4-tod-lkml/include/asm-ia64/timeofday.h 2.6.12-rc4-tod/include/asm-ia64/timeofday.h
--- 2.6.12-rc4-tod-lkml/include/asm-ia64/timeofday.h	1969-12-31 16:00:00.000000000 -0800
+++ 2.6.12-rc4-tod/include/asm-ia64/timeofday.h	2005-05-17 13:01:12.000000000 -0700
@@ -0,0 +1,4 @@
+#ifndef _ASM_IA64_TIMEOFDAY_H
+#define _ASM_IA64_TIMEOFDAY_H
+#include <asm-generic/timeofday.h>
+#endif
diff -urpN 2.6.12-rc4-tod-lkml/include/asm-ppc/timeofday.h 2.6.12-rc4-tod/include/asm-ppc/timeofday.h
--- 2.6.12-rc4-tod-lkml/include/asm-ppc/timeofday.h	1969-12-31 16:00:00.000000000 -0800
+++ 2.6.12-rc4-tod/include/asm-ppc/timeofday.h	2005-05-17 13:01:12.000000000 -0700
@@ -0,0 +1,4 @@
+#ifndef _ASM_PPC_TIMEOFDAY_H
+#define _ASM_PPC_TIMEOFDAY_H
+#include <asm-generic/timeofday.h>
+#endif
diff -urpN 2.6.12-rc4-tod-lkml/include/asm-ppc64/timeofday.h 2.6.12-rc4-tod/include/asm-ppc64/timeofday.h
--- 2.6.12-rc4-tod-lkml/include/asm-ppc64/timeofday.h	1969-12-31 16:00:00.000000000 -0800
+++ 2.6.12-rc4-tod/include/asm-ppc64/timeofday.h	2005-05-17 13:01:12.000000000 -0700
@@ -0,0 +1,4 @@
+#ifndef _ASM_PPC64_TIMEOFDAY_H
+#define _ASM_PPC64_TIMEOFDAY_H
+#include <asm-generic/timeofday.h>
+#endif
diff -urpN 2.6.12-rc4-tod-lkml/include/asm-s390/timeofday.h 2.6.12-rc4-tod/include/asm-s390/timeofday.h
--- 2.6.12-rc4-tod-lkml/include/asm-s390/timeofday.h	1969-12-31 16:00:00.000000000 -0800
+++ 2.6.12-rc4-tod/include/asm-s390/timeofday.h	2005-05-17 13:01:12.000000000 -0700
@@ -0,0 +1,4 @@
+#ifndef _ASM_S390_TIMEOFDAY_H
+#define _ASM_S390_TIMEOFDAY_H
+#include <asm-generic/timeofday.h>
+#endif
diff -urpN 2.6.12-rc4-tod-lkml/include/asm-x86_64/timeofday.h 2.6.12-rc4-tod/include/asm-x86_64/timeofday.h
--- 2.6.12-rc4-tod-lkml/include/asm-x86_64/timeofday.h	1969-12-31 16:00:00.000000000 -0800
+++ 2.6.12-rc4-tod/include/asm-x86_64/timeofday.h	2005-05-17 13:01:12.000000000 -0700
@@ -0,0 +1,4 @@
+#ifndef _ASM_X86_64_TIMEOFDAY_H
+#define _ASM_X86_64_TIMEOFDAY_H
+#include <asm-generic/timeofday.h>
+#endif
diff -urpN 2.6.12-rc4-tod-lkml/include/linux/timeofday.h 2.6.12-rc4-tod/include/linux/timeofday.h
--- 2.6.12-rc4-tod-lkml/include/linux/timeofday.h	2005-05-17 15:29:29.000000000 -0700
+++ 2.6.12-rc4-tod/include/linux/timeofday.h	2005-05-17 13:01:12.000000000 -0700
@@ -7,7 +7,6 @@
 #include <linux/types.h>
 #include <linux/time.h>
 #include <linux/timex.h>
-#include <linux/timesource.h>
 #include <asm/div64.h>
 
 #ifdef CONFIG_NEWTOD
@@ -23,19 +22,6 @@ extern int do_adjtimex(struct timex *tx)
 
 extern void timeofday_init(void);
 
-
-/* Required externs */
-/* XXX - should this go elsewhere? */
-extern nsec_t read_persistent_clock(void);
-extern void sync_persistent_clock(struct timespec ts);
-#ifdef CONFIG_NEWTOD_VSYSCALL
-extern void arch_update_vsyscall_gtod(nsec_t wall_time, cycle_t offset_base,
-				struct timesource_t* timesource, int ntp_adj);
-#else
-#define arch_update_vsyscall_gtod(x,y,z,w) {}
-#endif
-
-
 /* Inline helper functions */
 static inline struct timeval ns_to_timeval(nsec_t ns)
 {
diff -urpN 2.6.12-rc4-tod-lkml/kernel/timeofday.c 2.6.12-rc4-tod/kernel/timeofday.c
--- 2.6.12-rc4-tod-lkml/kernel/timeofday.c	2005-05-17 15:29:29.000000000 -0700
+++ 2.6.12-rc4-tod/kernel/timeofday.c	2005-05-17 13:01:12.000000000 -0700
@@ -58,6 +58,7 @@
 #include <linux/sched.h> /* Needed for capable() */
 #include <linux/sysdev.h>
 #include <linux/jiffies.h>
+#include <asm/timeofday.h>
 
 /* XXX - remove later */
 #define TIME_DBG 0

  reply	other threads:[~2005-05-17 23:39 UTC|newest]

Thread overview: 35+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-14  0:16 [RFC][PATCH (1/7)] new timeofday subsystem (v A5) john stultz
2005-05-14  0:17 ` [RFC][PATCH (2/7)] new timeofday i386 arch specific changes " john stultz
2005-05-14  0:19   ` [RFC][PATCH (3/7)] new timeofday x86-64 " john stultz
2005-05-14  0:20     ` [RFC][PATCH (4/7)] new timeofday i386 and x86-64 timesources " john stultz
2005-05-14  0:22       ` [RFC][PATCH (5/7)] new timeofday ia64,ppc32,ppc64 and s390 arch specific hooks " john stultz
2005-05-14  0:23         ` [RFC][PATCH (6/7)] new timeofday ia64,ppc32,ppc64 and s390 timesources " john stultz
2005-05-14  0:27           ` [RFC][PATCH (7/7)] new timeofday i386 vsyscall proof of concept " john stultz
2005-05-16 21:53             ` john stultz
2005-05-14 19:55         ` IA64 implementation of timesource for new time of day subsystem Christoph Lameter
2005-05-15 10:22           ` James Courtier-Dutton
2005-05-15 10:17             ` Andi Kleen
2005-05-16 15:30               ` Chris Friesen
2005-05-16 17:34           ` john stultz
2005-05-16 18:09             ` Christoph Lameter
2005-05-16 18:45               ` john stultz
2005-05-16 18:55                 ` john stultz
2005-05-16 19:24                 ` Christoph Lameter
2005-05-16 19:29                   ` David Mosberger
2005-05-16 19:50                     ` john stultz
2005-05-16 20:27                       ` Christoph Lameter
2005-05-16 20:53                         ` john stultz
2005-05-16 20:58                           ` David Mosberger
2005-05-16 21:35                             ` john stultz
2005-05-16 21:53                               ` Christoph Lameter
2005-05-17  8:05                     ` Ulrich Windl
2005-05-16 18:52     ` [RFC][PATCH (3/7)] new timeofday x86-64 specific changes (v A5) john stultz
2005-05-17 23:33 ` [RFC][PATCH 0/4] new timeofday-based soft-timer subsystem Nishanth Aravamudan
2005-05-17 23:34   ` Nishanth Aravamudan [this message]
2005-05-17 23:36   ` [RFC][PATCH 2/4] convert soft-timer subsystem to timerintervals Nishanth Aravamudan
2005-05-18  8:21     ` [RFC][UPDATE PATCH " Nishanth Aravamudan
2005-05-18 15:59       ` Jonathan Corbet
2005-05-18 17:00         ` Nishanth Aravamudan
2005-05-17 23:37   ` [RFC][PATCH 3/4] convert sys_nanosleep() to use new soft-timer subsystem Nishanth Aravamudan
2005-05-17 23:38   ` [RFC][PATCH 4/4] support new soft-timer subsystem on non-NEWTOD archs Nishanth Aravamudan
2005-05-19 23:29   ` [RFC][PATCH 0/4] new timeofday-based soft-timer subsystem Nishanth Aravamudan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050517233425.GF2735@us.ibm.com \
    --to=nacc@us.ibm.com \
    --cc=ak@suse.de \
    --cc=albert@users.sourceforge.net \
    --cc=anton@samba.org \
    --cc=benh@kernel.crashing.org \
    --cc=clameter@sgi.com \
    --cc=darren@dvhart.com \
    --cc=davidm@hpl.hp.com \
    --cc=djwong@us.ibm.com \
    --cc=donf@us.ibm.com \
    --cc=george@mvista.com \
    --cc=johnstul@us.ibm.com \
    --cc=kmannth@us.ibm.com \
    --cc=lcm@us.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@dominikbrodowski.de \
    --cc=mahuja@us.ibm.com \
    --cc=masbock@us.ibm.com \
    --cc=mpm@selenic.com \
    --cc=paulus@samba.org \
    --cc=schwidefsky@de.ibm.com \
    --cc=tim@physik3.uni-rostock.de \
    --cc=ulrich.windl@rz.uni-regensburg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox