public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Chris Wright <chrisw@osdl.org>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: "David S. Miller" <davem@davemloft.net>,
	Linux Audit Discussion <linux-audit@redhat.com>,
	linux-kernel@vger.kernel.org, netdev@oss.sgi.com,
	Chris Wright <chrisw@osdl.org>
Subject: Re: 2.6.12-rc4-mm2 - sleeping function called from invalid context at mm/slab.c:2502
Date: Wed, 18 May 2005 10:00:33 -0700	[thread overview]
Message-ID: <20050518170033.GT27549@shell0.pdx.osdl.net> (raw)
In-Reply-To: <20050518083002.GA30689@gondor.apana.org.au>

* Herbert Xu (herbert@gondor.apana.org.au) wrote:
> Guys, please CC netdev on issues like this.

Sorry Herbert, we hadn't yet concluded that it's not an issue that we
need to resolve within audit.

> On Tue, May 17, 2005 at 05:43:00PM +0000, Chris Wright wrote:
> > 
> > This has some issues w.r.t. truesize and socket buffer space.  The trim
> > is done to keep accounting sane, so we'd either have to trim ourselves
> > or take into account the change in size.  And ultimately, we'd still get
> > trimmed by netlink, so the GFP issue is still there.  Ideally, gfp_any()
> > would really be _any_
> 
> The trimming is completely optional.  That is, if the allocation fails
> nothing bad will happen.  So the solution is to simply use GFP_ATOMIC.

Well, it does more pressure on atomic pool (for those cases that
GFP_KERNEL would have sufficed).

thanks,
-chris

  reply	other threads:[~2005-05-18 17:02 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-17 16:24 2.6.12-rc4-mm2 - sleeping function called from invalid context at mm/slab.c:2502 Valdis.Kletnieks
2005-05-17 16:55 ` Chris Wright
2005-05-17 17:04   ` David Woodhouse
2005-05-17 17:43     ` Chris Wright
2005-05-18  8:30       ` Herbert Xu
2005-05-18 17:00         ` Chris Wright [this message]
2005-05-18 17:52           ` David Woodhouse
2005-05-18 21:29             ` Herbert Xu
2005-05-17 18:01   ` Valdis.Kletnieks
2005-05-19 11:34 ` David Woodhouse
2005-05-19 18:45   ` Valdis.Kletnieks
2005-05-20 14:30     ` Valdis.Kletnieks
2005-05-20 14:59       ` David Woodhouse
2005-05-20 15:09         ` Stephen Smalley
2005-05-20 15:36           ` David Woodhouse
2005-05-20 16:40             ` Stephen Smalley
2005-05-20 16:55               ` David Woodhouse
2005-05-20 16:58                 ` Stephen Smalley
2005-05-20 17:26                 ` Stephen Smalley
2005-05-20 23:27                   ` David Woodhouse
2005-05-20 17:01               ` Chris Wright
2005-05-20 17:05                 ` Stephen Smalley
2005-05-20 17:19                   ` Chris Wright
2005-05-20 17:05               ` David Woodhouse
2005-05-20 17:06                 ` Stephen Smalley
2005-05-20 16:41             ` Chris Wright

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050518170033.GT27549@shell0.pdx.osdl.net \
    --to=chrisw@osdl.org \
    --cc=davem@davemloft.net \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-audit@redhat.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox