From: Andi Kleen <ak@muc.de>
To: Terence Ripperda <tripperda@nvidia.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: problems with 2.6.12 and ioremap/iounmap
Date: 19 May 2005 01:51:28 +0200
Date: Thu, 19 May 2005 01:51:28 +0200 [thread overview]
Message-ID: <20050518235128.GA45952@muc.de> (raw)
In-Reply-To: <20050518233425.GB8962@hygelac>
On Wed, May 18, 2005 at 06:34:25PM -0500, Terence Ripperda wrote:
> > > perhaps iounmap should be calling ioremap_change_attr rather than
> >
> > What is ioremap_change_attr?
>
> a static function in ioremap.c that is called by __ioremap. it's a
> wrapper function around change_page_attr. I only see it in the x86_64
> architecture, not i386.
Oh yes, indeed. I forgot that I wrote it :) Calling global_flush_tlb
in iounmap is indeed a very good idea.
-Andi
prev parent reply other threads:[~2005-05-18 23:51 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-18 22:43 problems with 2.6.12 and ioremap/iounmap Terence Ripperda
2005-05-18 23:29 ` Andi Kleen
2005-05-18 23:34 ` Terence Ripperda
2005-05-18 23:51 ` Andi Kleen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050518235128.GA45952@muc.de \
--to=ak@muc.de \
--cc=linux-kernel@vger.kernel.org \
--cc=tripperda@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox