Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver

Greg KH
2005-05-19T03:27:41Z

On Wed, May 18, 2005 at 01:13:42PM -0500, Abhay Salunke wrote:
> This is a resubmit of the patch after incorporating all the inputs
> from revieweres. This also has a fix where the packets were leaked in
> the function create_packet line#227.

You did not address the issues I had with your use of binary sysfs files
for all file types. Please fix that up.

Also, what's wrong with using the existing firmware interface in the
kernel?

thanks,

greg k-h