Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new Dell BIOS update driver

Marcel Holtmann
2005-06-02T21:52:03Z

Hi Abhay,

> This is a resubmit of the patch after incorporating all the inputs from revieweres.
> This has the hotplug firmware interface as suggested by many.
> Currently it does not suport reading back the data; I am workingon it and will add
> that feature as new patch.

please fix the coding style. We use tabs instead of spaces.

Make sure that all functions are static and clean your namespace. Even
if they are static it is still unclean.

It is <linux/firmware.h> and not "linux/firmware.h".

The Kconfig is missing a "select FW_LOADER".

Regards

Marcel