public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@kernel.crashing.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Andrew Morton <akpm@osdl.org>,
	Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2.6.12-rc4] Add EXPORT_SYMBOL for hotplug_path
Date: Thu, 19 May 2005 11:16:21 -0700	[thread overview]
Message-ID: <20050519181620.GL3771@smtp.west.cox.net> (raw)
In-Reply-To: <1116524429.6027.55.camel@laptopd505.fenrus.org>

On Thu, May 19, 2005 at 07:40:29PM +0200, Arjan van de Ven wrote:
> On Thu, 2005-05-19 at 09:43 -0700, Tom Rini wrote:
> > If CONFIG_INPUT is set as a module, it will not load as hotplug_path is
> > not a defined symbol.  Trivial fix is to EXPORT_SYMBOL hotplug_path.
> 
> shouldn't this be a _GPL export since it's quite internal to linux...

Doesn't matter to me.

Signed-off-by: Tom Rini <trini@kernel.crashing.org>

Index: lib/kobject_uevent.c
===================================================================
--- c7d7a187a2125518e655dfeadffd38156239ffc3/lib/kobject_uevent.c  (mode:100644)
+++ uncommitted/lib/kobject_uevent.c  (mode:100644)
@@ -21,6 +21,7 @@
 #include <linux/string.h>
 #include <linux/kobject_uevent.h>
 #include <linux/kobject.h>
+#include <linux/module.h>
 #include <net/sock.h>
 
 #define BUFFER_SIZE	1024	/* buffer for the hotplug env */
@@ -178,6 +179,7 @@
 
 #ifdef CONFIG_HOTPLUG
 char hotplug_path[HOTPLUG_PATH_LEN] = "/sbin/hotplug";
+EXPORT_SYMBOL_GPL(hotplug_path);
 u64 hotplug_seqnum;
 static DEFINE_SPINLOCK(sequence_lock);
 

-- 
Tom Rini
http://gate.crashing.org/~trini/

  reply	other threads:[~2005-05-19 18:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-19 16:43 [PATCH 2.6.12-rc4] Add EXPORT_SYMBOL for hotplug_path Tom Rini
2005-05-19 17:40 ` Arjan van de Ven
2005-05-19 18:16   ` Tom Rini [this message]
2005-05-19 18:29     ` Dave Jones
2005-05-20  5:18 ` Greg KH
2005-05-20  5:18   ` Dmitry Torokhov
2005-05-20  5:37     ` Greg KH
2005-05-20  7:12 ` Kay Sievers
2005-05-20 17:18   ` Tom Rini
2005-05-20 17:56     ` Kay Sievers
2005-05-20 19:07       ` Dmitry Torokhov
2005-05-20 19:48         ` Kay Sievers
2005-05-20 20:11           ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050519181620.GL3771@smtp.west.cox.net \
    --to=trini@kernel.crashing.org \
    --cc=akpm@osdl.org \
    --cc=arjan@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox