From: Greg KH <greg@kroah.com>
To: Dmitry Torokhov <dtor_core@ameritech.net>
Cc: linux-kernel@vger.kernel.org,
Tom Rini <trini@kernel.crashing.org>,
Andrew Morton <akpm@osdl.org>
Subject: Re: [PATCH 2.6.12-rc4] Add EXPORT_SYMBOL for hotplug_path
Date: Thu, 19 May 2005 22:37:01 -0700 [thread overview]
Message-ID: <20050520053701.GA10697@kroah.com> (raw)
In-Reply-To: <200505200018.24129.dtor_core@ameritech.net>
On Fri, May 20, 2005 at 12:18:23AM -0500, Dmitry Torokhov wrote:
> On Friday 20 May 2005 00:18, Greg KH wrote:
> > On Thu, May 19, 2005 at 09:43:23AM -0700, Tom Rini wrote:
> > > If CONFIG_INPUT is set as a module, it will not load as hotplug_path is
> > > not a defined symbol. Trivial fix is to EXPORT_SYMBOL hotplug_path.
> > >
> > > Signed-off-by: Tom Rini <trini@kernel.crashing.org>
> >
> > Ick, no, I thought we got rid of that usage. no one should be calling
> > hotplug on their own, lots of bad things happen to udevd and HAL if they
> > do.
> >
> > What caused the input code to be added back into the kernel? I'll try
> > to go track that down...
> >
>
> The change never made it into the kernel. And I need to finish proper
> input_dev sysfs conversion...
Ah, ok, thanks. So I'll ACK the EXPORT_SYMBOL_GPL() version of this
patch for now.
thanks,
greg k-h
next prev parent reply other threads:[~2005-05-20 6:25 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-19 16:43 [PATCH 2.6.12-rc4] Add EXPORT_SYMBOL for hotplug_path Tom Rini
2005-05-19 17:40 ` Arjan van de Ven
2005-05-19 18:16 ` Tom Rini
2005-05-19 18:29 ` Dave Jones
2005-05-20 5:18 ` Greg KH
2005-05-20 5:18 ` Dmitry Torokhov
2005-05-20 5:37 ` Greg KH [this message]
2005-05-20 7:12 ` Kay Sievers
2005-05-20 17:18 ` Tom Rini
2005-05-20 17:56 ` Kay Sievers
2005-05-20 19:07 ` Dmitry Torokhov
2005-05-20 19:48 ` Kay Sievers
2005-05-20 20:11 ` Dmitry Torokhov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050520053701.GA10697@kroah.com \
--to=greg@kroah.com \
--cc=akpm@osdl.org \
--cc=dtor_core@ameritech.net \
--cc=linux-kernel@vger.kernel.org \
--cc=trini@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox