public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* Double 'block' link for floppy
@ 2005-05-21 21:54 Russell King
  2005-05-22 15:33 ` Jesper Juhl
  0 siblings, 1 reply; 3+ messages in thread
From: Russell King @ 2005-05-21 21:54 UTC (permalink / raw)
  To: Linux Kernel List, viro

I'm seeing an oddity with floppy:

$ vdir /sys/devices/platform/floppy.0/
total 0
lrwxrwxrwx    1 root     root            0 May 21 22:43 block -> ../../../block/fd1
lrwxrwxrwx    1 root     root            0 May 21 22:43 block -> ../../../block/fd1
lrwxrwxrwx    1 root     root            0 May 21 22:43 bus -> ../../../bus/platform
-rw-r--r--    1 root     root         4096 May 21 22:43 detach_state

I suspect the first is actually supposed to be 'fd0' since:

$ vdir /sys/block/fd*/device
lrwxrwxrwx    1 root     root            0 May 21 22:52 /sys/block/fd0/device -> ../../devices/platform/floppy.0
lrwxrwxrwx    1 root     root            0 May 21 22:52 /sys/block/fd1/device -> ../../devices/platform/floppy.0

It seems that the block sysfs layer can't cope with one device having
multiple block devices hanging off it, which is the case with floppy
controllers.

Maybe a possible solution would be for the floppy driver to register
platform devices beneath the main device for each floppy drive?

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Double 'block' link for floppy
  2005-05-21 21:54 Double 'block' link for floppy Russell King
@ 2005-05-22 15:33 ` Jesper Juhl
  2005-05-22 15:51   ` Russell King
  0 siblings, 1 reply; 3+ messages in thread
From: Jesper Juhl @ 2005-05-22 15:33 UTC (permalink / raw)
  To: Russell King; +Cc: Linux Kernel List, viro

On 5/21/05, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> I'm seeing an oddity with floppy:
> 
> $ vdir /sys/devices/platform/floppy.0/
> total 0
> lrwxrwxrwx    1 root     root            0 May 21 22:43 block -> ../../../block/fd1
> lrwxrwxrwx    1 root     root            0 May 21 22:43 block -> ../../../block/fd1
> lrwxrwxrwx    1 root     root            0 May 21 22:43 bus -> ../../../bus/platform
> -rw-r--r--    1 root     root         4096 May 21 22:43 detach_state
> 
> I suspect the first is actually supposed to be 'fd0' since:
> 
> $ vdir /sys/block/fd*/device
> lrwxrwxrwx    1 root     root            0 May 21 22:52 /sys/block/fd0/device -> ../../devices/platform/floppy.0
> lrwxrwxrwx    1 root     root            0 May 21 22:52 /sys/block/fd1/device -> ../../devices/platform/floppy.0
> 

I just took a look here, and I don't see what you see : 

juhl@dragon:~$ uname -a
Linux dragon 2.6.12-rc4-mm2 #2 Mon May 16 18:14:13 CEST 2005 i686
unknown unknown GNU/Linux
juhl@dragon:~$ vdir /sys/devices/platform/floppy.0/
total 0
lrwxrwxrwx  1 root root 0 2005-05-22 17:35 block -> ../../../block/fd0/
lrwxrwxrwx  1 root root 0 2005-05-22 13:02 bus -> ../../../bus/platform/
drwxr-xr-x  2 root root 0 2005-05-22 13:01 power/
juhl@dragon:~$ vdir /sys/block/fd*/device
lrwxrwxrwx  1 root root 0 2005-05-22 13:02 /sys/block/fd0/device ->
../../devices/platform/floppy.0/
juhl@dragon:~$

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: Double 'block' link for floppy
  2005-05-22 15:33 ` Jesper Juhl
@ 2005-05-22 15:51   ` Russell King
  0 siblings, 0 replies; 3+ messages in thread
From: Russell King @ 2005-05-22 15:51 UTC (permalink / raw)
  To: Jesper Juhl; +Cc: Linux Kernel List, viro

On Sun, May 22, 2005 at 05:33:55PM +0200, Jesper Juhl wrote:
> On 5/21/05, Russell King <rmk+lkml@arm.linux.org.uk> wrote:
> > I'm seeing an oddity with floppy:
> > 
> > $ vdir /sys/devices/platform/floppy.0/
> > total 0
> > lrwxrwxrwx    1 root     root            0 May 21 22:43 block -> ../../../block/fd1
> > lrwxrwxrwx    1 root     root            0 May 21 22:43 block -> ../../../block/fd1
> > lrwxrwxrwx    1 root     root            0 May 21 22:43 bus -> ../../../bus/platform
> > -rw-r--r--    1 root     root         4096 May 21 22:43 detach_state
> > 
> > I suspect the first is actually supposed to be 'fd0' since:
> > 
> > $ vdir /sys/block/fd*/device
> > lrwxrwxrwx    1 root     root            0 May 21 22:52 /sys/block/fd0/device -> ../../devices/platform/floppy.0
> > lrwxrwxrwx    1 root     root            0 May 21 22:52 /sys/block/fd1/device -> ../../devices/platform/floppy.0
> > 
> 
> I just took a look here, and I don't see what you see : 

That'll be because your system is obviously configured for only one
floppy drive.  Configure it for two and see what happens.  (Naturally
the BIOS will complain if you don't actually have a second drive.)

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:  2.6 Serial core

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2005-05-22 15:51 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-21 21:54 Double 'block' link for floppy Russell King
2005-05-22 15:33 ` Jesper Juhl
2005-05-22 15:51   ` Russell King

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox