Re: [patch 2.6.12-rc3] dell_rbu: Resubmitting patch for new DellBIOS update driver

[Greg KH <greg@kroah.com>]

On Mon, May 23, 2005 at 10:36:37AM -0500, Abhay_Salunke@Dell.com wrote:
> > > > Also, what's wrong with using the existing firmware interface in the
> > > > kernel?
> > > request_firmware requires the $FIRMWARE env to be populated with the
> > > firmware image name or the firmware image name needs to be hardcoded
> > > within  the call to request_firmware.
> > 
> > the latter one. Don't mess with the $FIRMWARE env, because this comes
> > from the kernel hotplug call.
> > 
> > > Since the user is free to change
> > > the BIOS update image at will, it may not be possible if we use
> > > $FIRMWARE also I am not sure if this env variable might be conflicting
> > > to some other driver.
> > 
> > I am not quite sure what's the problem here. Tell the kernel what
> > firmware image to request. Something like
> > 
> > 	echo "firmware-filename" > /sys/firmware/dell_rbu/download
> > 
> Looks like request_firmware is causing lots of changes in my code. For
> now I would just focus on getting the size parameters in normal sysfs
> attribute and do request_firmware some time later as a separate patch.

Well, as they will be the "correct" type of changes, I recommend you do
them too :)

thanks,

greg k-h