Re: [patch 1/4] CPU Hotplug support for X86_64

Andi Kleen
2005-05-24T18:20:04Z

On Tue, May 24, 2005 at 08:51:13AM -0700, Ashok Raj wrote:
> On Tue, May 24, 2005 at 02:15:42PM +0200, Andi Kleen wrote:
> > On Tue, May 24, 2005 at 01:11:14AM -0700, Ashok Raj wrote:
> > > * RED-PEN audit/test this more. I bet there is more state messed up here.
> > > */
> > > -static __cpuinit void disable_smp(void)
> > > +static __init void disable_smp(void)
> >
> > Why all these cpuinit->init changes? I think they should stay __cpuinit
> >
> > The other way round looks ok.
>
> disable_smp() is called only in smp_prepare_cpus() which is not required
> for hotplug. Its currently only required only for startup, and not later.
>
> I changed the ones from __cpuinit to __init, just in functions marked
> with paranoia... i think it can stay cpuinit, unless there is another reason
> i didnt catch.

Ok. Makes sense.

But how about all the other functions that you changed too? Can you
double check them. SOme looked suspicious.

-Andi