From: Andi Kleen <ak@muc.de>
To: Ashok Raj <ashok.raj@intel.com>
Cc: akpm@osdl.org, zwane@arm.linux.org.uk, rusty@rustycorp.com.au,
vatsa@in.ibm.com, shaohua.li@intel.com,
linux-kernel@vger.kernel.org, discuss@x86-64.org
Subject: Re: [patch 3/4] CPU Hotplug support for X86_64
Date: 24 May 2005 14:27:00 +0200
Date: Tue, 24 May 2005 14:27:00 +0200 [thread overview]
Message-ID: <20050524122700.GC86182@muc.de> (raw)
In-Reply-To: <20050524081304.805933000@csdlinux-2.jf.intel.com>
On Tue, May 24, 2005 at 01:11:16AM -0700, Ashok Raj wrote:
> ===================================================================
> --- linux-2.6.12-rc4-mm2.orig/arch/x86_64/kernel/smpboot.c
> +++ linux-2.6.12-rc4-mm2/arch/x86_64/kernel/smpboot.c
> @@ -62,9 +62,12 @@
> /* Number of siblings per CPU package */
> int smp_num_siblings = 1;
> /* Package ID of each logical CPU */
> -u8 phys_proc_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
> -u8 cpu_core_id[NR_CPUS] = { [0 ... NR_CPUS-1] = BAD_APICID };
> +u8 phys_proc_id[NR_CPUS] __cacheline_aligned =
> + { [0 ... NR_CPUS-1] = BAD_APICID };
Why this change?
> EXPORT_SYMBOL(phys_proc_id);
> +
> +u8 cpu_core_id[NR_CPUS] __cacheline_aligned =
> + { [0 ... NR_CPUS-1] = BAD_APICID };
And that one?
It does not seem related to CPUhotplug. May as a separate patch,
but in this case the "per cpu readonly" section C.Lameter recently
added should be used for these which are near always read-only
(I hope the section made it into -mm* now)
-Andi
next prev parent reply other threads:[~2005-05-24 12:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-24 8:11 [patch 0/4] CPU Hotplug support for X86_64 Ashok Raj
2005-05-24 8:11 ` [patch 1/4] " Ashok Raj
2005-05-24 12:15 ` Andi Kleen
2005-05-24 15:51 ` Ashok Raj
2005-05-24 18:18 ` Andi Kleen
2005-05-24 8:11 ` [patch 2/4] " Ashok Raj
2005-05-24 12:24 ` Andi Kleen
2005-05-24 8:11 ` [patch 3/4] " Ashok Raj
2005-05-24 12:27 ` Andi Kleen [this message]
2005-05-24 8:11 ` [patch 4/4] " Ashok Raj
2005-05-24 12:28 ` Andi Kleen
2005-05-24 9:31 ` [patch 0/4] " Shaohua Li
2005-05-25 22:16 ` Matthew Dobson
2005-05-26 0:11 ` Ashok Raj
-- strict thread matches above, loose matches on Subject: below --
2005-05-24 7:27 Ashok Raj
2005-05-24 7:27 ` [patch 3/4] " Ashok Raj
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050524122700.GC86182@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=ashok.raj@intel.com \
--cc=discuss@x86-64.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rusty@rustycorp.com.au \
--cc=shaohua.li@intel.com \
--cc=vatsa@in.ibm.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox