From: Andi Kleen <ak@muc.de>
To: Prasanna S Panchamukhi <prasanna@in.ibm.com>
Cc: akpm@osdl.org, davem@davemloft.net, linux-kernel@vger.kernel.org,
systemtap@sources.redhat.com
Subject: Re: [PATCH 1/5] Kprobes: Temporary disarming of reentrant probe
Date: 24 May 2005 20:15:25 +0200
Date: Tue, 24 May 2005 20:15:25 +0200 [thread overview]
Message-ID: <20050524181525.GF86233@muc.de> (raw)
In-Reply-To: <20050524101532.GA27215@in.ibm.com>
> @@ -55,6 +61,9 @@ struct kprobe {
> /* list of kprobes for multi-handler support */
> struct list_head list;
>
> + /*count the number of times this probe was temporarily disarmed */
> + unsigned long nmissed;
You declare a variable.
> +
> /* location of the probe point */
> kprobe_opcode_t *addr;
>
> diff -puN kernel/kprobes.c~kprobes-temporary-disarming-on-reentrancy-generic kernel/kprobes.c
> --- linux-2.6.12-rc4-mm2/kernel/kprobes.c~kprobes-temporary-disarming-on-reentrancy-generic 2005-05-24 15:28:08.000000000 +0530
> +++ linux-2.6.12-rc4-mm2-prasanna/kernel/kprobes.c 2005-05-24 15:28:08.000000000 +0530
> @@ -334,6 +334,7 @@ int register_kprobe(struct kprobe *p)
> }
> spin_lock_irqsave(&kprobe_lock, flags);
> old_p = get_kprobe(p->addr);
> + p->nmissed = 0;
And then you set it to 0.
And nothing more. Surely this patch does not do anything. Looks like
some code is missing.
-Andi
next prev parent reply other threads:[~2005-05-24 18:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-24 10:15 [PATCH 1/5] Kprobes: Temporary disarming of reentrant probe Prasanna S Panchamukhi
2005-05-24 10:17 ` [PATCH 2/5] Kprobes: Temporary disarming of reentrant probe for i386 Prasanna S Panchamukhi
2005-05-24 10:18 ` [PATCH 3/5] Kprobes: Temporary disarming of reentrant probe for x86_64 Prasanna S Panchamukhi
2005-05-24 10:19 ` [PATCH 4/5] Kprobes: Temporary disarming of reentrant probe for ppc64 Prasanna S Panchamukhi
2005-05-24 10:20 ` [PATCH 5/5] Kprobes: Temporary disarming of reentrant probe for sparc64 Prasanna S Panchamukhi
2005-05-24 18:13 ` [PATCH 3/5] Kprobes: Temporary disarming of reentrant probe for x86_64 Andi Kleen
2005-05-25 15:19 ` [PATCH 2/5] Kprobes: Temporary disarming of reentrant probe for i386 Andi Kleen
2005-05-24 18:15 ` Andi Kleen [this message]
2005-05-24 18:21 ` [PATCH 1/5] Kprobes: Temporary disarming of reentrant probe Ananth N Mavinakayanahalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050524181525.GF86233@muc.de \
--to=ak@muc.de \
--cc=akpm@osdl.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=prasanna@in.ibm.com \
--cc=systemtap@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox