The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Paul Jackson <pj@sgi.com>
To: dino@in.ibm.com
Cc: akpm@osdl.org, torvalds@osdl.org, Simon.Derr@bull.net,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.12-rc4] cpuset rmdir scheduling while atomic fix
Date: Thu, 26 May 2005 11:26:33 -0700	[thread overview]
Message-ID: <20050526112633.5a8c3f84.pj@sgi.com> (raw)
In-Reply-To: <20050526143315.GB7068@in.ibm.com>

Dinakar wrote:
> This was the same problem that I had reported earlier
> and fixed as well

You're right.  I even signed off on your change.

Andrew,

    Drop my "cpuset rmdir scheduling while atomic fix" patch. 

    Dinakar's dynamic-sched-domains-cpuset-changes.patch fixed it.

Dinakar's change wasn't quite the same as mine.  It is actually the
better of the two - it reduces the dentry spinlock region, instead of
moving the cpuset_sem region outside the spinlock.  I just ran my stress
test that shows this bug.  Dinakar's fix is fine, as expected.

-- 
                  I won't rest till it's the best ...
                  Programmer, Linux Scalability
                  Paul Jackson <pj@engr.sgi.com> 1.650.933.1373, 1.925.600.0401

      reply	other threads:[~2005-05-26 18:27 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-26  8:25 [PATCH 2.6.12-rc4] cpuset rmdir scheduling while atomic fix Paul Jackson
2005-05-26 12:41 ` Dinakar Guniguntala
2005-05-26 14:33   ` Dinakar Guniguntala
2005-05-26 18:26     ` Paul Jackson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050526112633.5a8c3f84.pj@sgi.com \
    --to=pj@sgi.com \
    --cc=Simon.Derr@bull.net \
    --cc=akpm@osdl.org \
    --cc=dino@in.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@osdl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox