From: Paul Jackson <pj@sgi.com>
To: Robin Holt <holt@sgi.com>
Cc: Simon.Derr@bull.net, akpm@osdl.org, dino@in.ibm.com,
torvalds@osdl.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2.6.12-rc4] cpuset exit NULL dereference fix
Date: Thu, 26 May 2005 13:46:35 -0700 [thread overview]
Message-ID: <20050526134635.4fd1b978.pj@sgi.com> (raw)
In-Reply-To: <20050526120859.GD29852@lnx-holt.americas.sgi.com>
Robin wrote:
> Whenever the refcount reaches 0, we
> automatically remove the cpuset.
If by this you mean replacing the usermodehelper callout to
/sbin/cpuset_release_agent, with a direct removal of the cpuset
in the kernel, then:
* this changes a kernel API - not to be done lightly, and
* adding an in-kernel way to nuke a cpuset, in addition to
having the rmdir(2) system call do it, seems like it would
present even thornier locking issues.
The usermodehelper callout is working just fine for us.
As to the rest of your post, proposing a per-cpuset spinlock,
see my previous reply to Simon.
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@engr.sgi.com> 1.650.933.1373, 1.925.600.0401
next prev parent reply other threads:[~2005-05-26 20:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-26 8:25 [PATCH 2.6.12-rc4] cpuset exit NULL dereference fix Paul Jackson
2005-05-26 9:00 ` Simon Derr
2005-05-26 12:08 ` Robin Holt
2005-05-26 15:44 ` Linus Torvalds
2005-05-26 18:46 ` Paul Jackson
2005-05-26 20:46 ` Paul Jackson [this message]
2005-05-26 13:54 ` Dinakar Guniguntala
2005-05-26 20:07 ` Paul Jackson
2005-05-27 0:24 ` Paul Jackson
2005-05-26 23:40 ` Paul Jackson
2005-05-27 8:07 ` Simon Derr
2005-05-27 8:44 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050526134635.4fd1b978.pj@sgi.com \
--to=pj@sgi.com \
--cc=Simon.Derr@bull.net \
--cc=akpm@osdl.org \
--cc=dino@in.ibm.com \
--cc=holt@sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox