From: Dave Jones <davej@redhat.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Andrew Morton <akpm@osdl.org>, David Airlie <airlied@linux.ie>,
Linux Kernel Development <linux-kernel@vger.kernel.org>,
dri-devel@lists.sourceforge.net
Subject: Re: [PATCH] DRM depends on ???
Date: Sat, 28 May 2005 17:50:05 -0400 [thread overview]
Message-ID: <20050528215005.GA5990@redhat.com> (raw)
In-Reply-To: <Pine.LNX.4.62.0505282333210.5800@anakin>
On Sat, May 28, 2005 at 11:39:00PM +0200, Geert Uytterhoeven wrote:
>
> DRM depending on `AGP=n' is driving me crazy! How to make CONFIG_DRM not
> eligible for selection on platforms that do not have AGP?
>
> Since many of the core DRM files depend on PCI, add a dependency on PCI,
> to minimize the damage.
>
> Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
>
> --- linux-2.6.12-rc5/drivers/char/drm/Kconfig 2005-05-25 19:37:53.000000000 +0200
> +++ linux-m68k-2.6.12-rc5/drivers/char/drm/Kconfig 2005-04-05 10:12:41.000000000 +0200
> @@ -6,7 +6,7 @@
> #
> config DRM
> tristate "Direct Rendering Manager (XFree86 4.1.0 and higher DRI support)"
> - depends on AGP || AGP=n
> + depends on (AGP || AGP=n) && PCI
The whole dependancy seems like nonsense to me.
I think
depends on PCI
is a lot more sensible.
Dave
next prev parent reply other threads:[~2005-05-28 21:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-28 21:39 [PATCH] DRM depends on ??? Geert Uytterhoeven
2005-05-28 21:50 ` Dave Jones [this message]
2005-05-29 4:25 ` Kyle Moffett
2005-05-29 7:11 ` Dave Airlie
2005-05-29 19:58 ` Geert Uytterhoeven
2005-05-29 23:00 ` Kyle Moffett
2005-05-30 8:03 ` Geert Uytterhoeven
2005-05-30 8:54 ` Dave Airlie
2005-05-30 9:12 ` Geert Uytterhoeven
2005-05-30 11:12 ` Helge Hafting
2005-05-30 11:19 ` Dave Airlie
2005-05-29 8:26 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050528215005.GA5990@redhat.com \
--to=davej@redhat.com \
--cc=airlied@linux.ie \
--cc=akpm@osdl.org \
--cc=dri-devel@lists.sourceforge.net \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox