From: domen@coderock.org
To: ysato@users.sourceforge.jp
Cc: linux-kernel@vger.kernel.org, domen@coderock.org
Subject: [patch 1/1] ptrace_h8300: condition bugfix
Date: Sun, 29 May 2005 01:16:28 +0200 [thread overview]
Message-ID: <20050528231627.776377000@nd47.coderock.org> (raw)
[-- Attachment #1: condition_assignment-arch_h8300_platform_h8300h_ptrace_h8300h --]
[-- Type: text/plain, Size: 1184 bytes --]
From: Domen Puncer <domen@coderock.org>
Assignment doesn't make much sense here as condition would always be
true.
Signed-off-by: Domen Puncer <domen@coderock.org>
---
ptrace_h8300h.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Index: quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c
===================================================================
--- quilt.orig/arch/h8300/platform/h8300h/ptrace_h8300h.c
+++ quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c
@@ -245,12 +245,12 @@ static unsigned short *getnextpc(struct
addr = h8300_get_reg(child, regno-1+PT_ER1);
return (unsigned short *)addr;
case relb:
- if ((inst = 0x55) || isbranch(child,inst & 0x0f))
+ if (inst == 0x55 || isbranch(child,inst & 0x0f))
pc = (unsigned short *)((unsigned long)pc +
((signed char)(*fetch_p)));
return pc+1; /* skip myself */
case relw:
- if ((inst = 0x5c) || isbranch(child,(*fetch_p & 0xf0) >> 4))
+ if (inst == 0x5c || isbranch(child,(*fetch_p & 0xf0) >> 4))
pc = (unsigned short *)((unsigned long)pc +
((signed short)(*(pc+1))));
return pc+2; /* skip myself */
--
next reply other threads:[~2005-05-28 23:16 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-28 23:16 domen [this message]
2005-05-30 6:32 ` [patch 1/1] ptrace_h8300: condition bugfix Yoshinori Sato
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050528231627.776377000@nd47.coderock.org \
--to=domen@coderock.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ysato@users.sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox