* [patch 1/1] ptrace_h8300: condition bugfix
@ 2005-05-28 23:16 domen
2005-05-30 6:32 ` Yoshinori Sato
0 siblings, 1 reply; 2+ messages in thread
From: domen @ 2005-05-28 23:16 UTC (permalink / raw)
To: ysato; +Cc: linux-kernel, domen
[-- Attachment #1: condition_assignment-arch_h8300_platform_h8300h_ptrace_h8300h --]
[-- Type: text/plain, Size: 1184 bytes --]
From: Domen Puncer <domen@coderock.org>
Assignment doesn't make much sense here as condition would always be
true.
Signed-off-by: Domen Puncer <domen@coderock.org>
---
ptrace_h8300h.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Index: quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c
===================================================================
--- quilt.orig/arch/h8300/platform/h8300h/ptrace_h8300h.c
+++ quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c
@@ -245,12 +245,12 @@ static unsigned short *getnextpc(struct
addr = h8300_get_reg(child, regno-1+PT_ER1);
return (unsigned short *)addr;
case relb:
- if ((inst = 0x55) || isbranch(child,inst & 0x0f))
+ if (inst == 0x55 || isbranch(child,inst & 0x0f))
pc = (unsigned short *)((unsigned long)pc +
((signed char)(*fetch_p)));
return pc+1; /* skip myself */
case relw:
- if ((inst = 0x5c) || isbranch(child,(*fetch_p & 0xf0) >> 4))
+ if (inst == 0x5c || isbranch(child,(*fetch_p & 0xf0) >> 4))
pc = (unsigned short *)((unsigned long)pc +
((signed short)(*(pc+1))));
return pc+2; /* skip myself */
--
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [patch 1/1] ptrace_h8300: condition bugfix
2005-05-28 23:16 [patch 1/1] ptrace_h8300: condition bugfix domen
@ 2005-05-30 6:32 ` Yoshinori Sato
0 siblings, 0 replies; 2+ messages in thread
From: Yoshinori Sato @ 2005-05-30 6:32 UTC (permalink / raw)
To: Andrew Morton, domen; +Cc: linux-kernel
At Sun, 29 May 2005 01:16:28 +0200,
domen@coderock.org wrote:
>
> From: Domen Puncer <domen@coderock.org>
>
>
> Assignment doesn't make much sense here as condition would always be
> true.
>
Thanks.
I applied it.
Signed-off-by: Domen Puncer <domen@coderock.org>
Signed-off-by: Yoshinori Sato <ysato@users.sourceforge.jp>
---
ptrace_h8300h.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
Index: quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c
===================================================================
--- quilt.orig/arch/h8300/platform/h8300h/ptrace_h8300h.c
+++ quilt/arch/h8300/platform/h8300h/ptrace_h8300h.c
@@ -245,12 +245,12 @@ static unsigned short *getnextpc(struct
addr = h8300_get_reg(child, regno-1+PT_ER1);
return (unsigned short *)addr;
case relb:
- if ((inst = 0x55) || isbranch(child,inst & 0x0f))
+ if (inst == 0x55 || isbranch(child,inst & 0x0f))
pc = (unsigned short *)((unsigned long)pc +
((signed char)(*fetch_p)));
return pc+1; /* skip myself */
case relw:
- if ((inst = 0x5c) || isbranch(child,(*fetch_p & 0xf0) >> 4))
+ if (inst == 0x5c || isbranch(child,(*fetch_p & 0xf0) >> 4))
pc = (unsigned short *)((unsigned long)pc +
((signed short)(*(pc+1))));
return pc+2; /* skip myself */
--
--
Yoshinori Sato
<ysato@users.sourceforge.jp>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-05-30 6:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-05-28 23:16 [patch 1/1] ptrace_h8300: condition bugfix domen
2005-05-30 6:32 ` Yoshinori Sato
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox