Re: Playing with SATA NCQ

Jeff Garzik
2005-05-26T17:17:02Z

Jens Axboe wrote:
> Re-reading AHCI spec, it does indicate that you want to set SActive
> after building the command. I'll move it back, but keep the conditional
> of setting SActive on queued commands.

SActive is intentionally used for non-NCQ devices. The SATA registers
are -host- registers not -device- registers, remember.

At the very least, I would like to see a lot of testing before you make
the current unconditional code conditional.

Jeff