public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@stusta.de>
To: Mikael Pettersson <mikpe@csd.uu.se>
Cc: Marcelo Tosatti <marcelo.tosatti@cyclades.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [2.4 patch] document that gcc 4 is not supported
Date: Mon, 30 May 2005 22:13:55 +0200	[thread overview]
Message-ID: <20050530201355.GN10441@stusta.de> (raw)
In-Reply-To: <17051.28464.67012.631845@alkaid.it.uu.se>

On Mon, May 30, 2005 at 09:53:20PM +0200, Mikael Pettersson wrote:
> Adrian Bunk writes:
>  > gcc 4 is not supported for compiling kernel 2.4, and I don't see any 
>  > compelling reason why kernel 2.4 should ever be adapted to gcc 4.
> ...
>  > --- linux-2.4.31-rc1-full/init/main.c.old	2005-05-30 21:20:00.000000000 +0200
>  > +++ linux-2.4.31-rc1-full/init/main.c	2005-05-30 21:21:19.000000000 +0200
>  > @@ -84,6 +84,13 @@
>  >  #error Sorry, your GCC is too old. It builds incorrect kernels.
>  >  #endif
>  >  
>  > +/*
>  > + * gcc >= 4 is not supported by kernel 2.4
>  > + */
>  > +#if __GNUC__ > 3
>  > +#error Sorry, your GCC is too recent for kernel 2.4
>  > +#endif
>  > +
>  >  extern char _stext, _etext;
>  >  extern char *linux_banner;
>  >  
> 
> This is redundant. Any attempt to compile vanilla 2.4 with gcc4
> will fail with compilation errors. (And except for one issue on
> x86-64 which actually was a kernel bug, those are the only known
> issues with using gcc4 for 2.4.)

Without this patch, your screen is flooded with warnings and errors when 
accidentially trying to compile kernel 2.4 with gcc 4.

With this patch, the same happens, but the last lines contain the 
explanation
  #error Sorry, your GCC is too recent for kernel 2.4

> OTOH, for those of us that do use gcc4, this just gets in the way
> and forces the gcc4 fixes kit for 2.4 to be even larger.
>...

If someone makes a patch to fix all issues with gcc 4, adding the 
removal of this #error should be the most trivial part of the patch.

> /Mikael

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


  reply	other threads:[~2005-05-30 20:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-30 19:28 [2.4 patch] document that gcc 4 is not supported Adrian Bunk
2005-05-30 19:53 ` Mikael Pettersson
2005-05-30 20:13   ` Adrian Bunk [this message]
  -- strict thread matches above, loose matches on Subject: below --
2006-01-06 20:37 Adrian Bunk
2006-01-06 21:11 ` Willy Tarreau
2006-01-06 21:54   ` Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050530201355.GN10441@stusta.de \
    --to=bunk@stusta.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marcelo.tosatti@cyclades.com \
    --cc=mikpe@csd.uu.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox