Re: [2.6 patch] drivers/ide/: possible cleanups

Adrian Bunk
2005-05-30T21:57:49Z

On Tue, May 31, 2005 at 07:44:36AM +1000, Benjamin Herrenschmidt wrote:
> On Mon, 2005-05-30 at 22:56 +0200, Adrian Bunk wrote:
> > This patch contains the following possible cleanups:
> > - pci/cy82c693.c: make a needlessly global function static
> > - remove the following unneeded EXPORT_SYMBOL's:
> > - ide-taskfile.c: do_rw_taskfile
> > - ide-iops.c: default_hwif_iops
> > - ide-iops.c: default_hwif_transport
> > - ide-iops.c: wait_for_ready
>
> Are we sure we want to do that ? That would mean never having IDE host
> controller drivers as modules...
>
> I was thinking about toying with that again for pmac one of these
> days ...
>
> It may be worth, however, to rename those exported symbols to ide_*

My patch only removes the EXPORT_SYMBOL's.

It's always trivial to re-add them when you need them.

> Ben.

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed