public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Harald Welte <laforge@gnumonks.org>
To: Oliver Neukum <oliver@neukum.org>
Cc: linux-usb-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [BUG] oops while completing async USB via usbdevio
Date: Tue, 31 May 2005 10:06:10 +0200	[thread overview]
Message-ID: <20050531080609.GI25536@sunbeam.de.gnumonks.org> (raw)
In-Reply-To: <200505310107.03747.oliver@neukum.org>

[-- Attachment #1: Type: text/plain, Size: 1112 bytes --]

On Tue, May 31, 2005 at 01:07:03AM +0200, Oliver Neukum wrote:
> 
> > and it prints "p->sighand == NULL" every time I exit a program while
> > using the usbdevio based driver.
> > 
> > consequently, the following patch 'fixed' the problem.  Please do not
> > consider this as a real fix, since there's certainly still a race
> > condition left.   Please use it as a hint to correctly fix the problem.
> 
> It would be cleaner to terminate all URBs a task has submitted when the
> task terminates.

so for every task termination, we do a linear search over the global
list of pending URB's and terminate those where urb->task ==
taks_to_kill?  Sounds a bit expensive, especially since you don't know
(before iteration) whether that task has actually ever dealt with
usbdevio or not.

-- 
- Harald Welte <laforge@gnumonks.org>          	        http://gnumonks.org/
============================================================================
"Privacy in residential applications is a desirable marketing option."
                                                  (ETSI EN 300 175-7 Ch. A6)

[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]

      reply	other threads:[~2005-05-31  8:06 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-30 19:44 [BUG] oops while completing async USB via usbdevio Harald Welte
2005-05-30 21:26 ` Harald Welte
2005-05-30 22:55   ` [linux-usb-devel] " David Brownell
2005-05-30 23:09     ` Oliver Neukum
2005-05-30 23:12       ` David Brownell
2005-05-31  8:04       ` Harald Welte
2005-05-31  8:48     ` Harald Welte
2005-05-31 11:45       ` Oliver Neukum
2005-05-31 18:53       ` David Brownell
2005-05-31 22:12         ` Harald Welte
2005-06-06 16:05           ` Harald Welte
2005-06-06 16:24             ` Alan Stern
2005-06-06 16:50               ` Harald Welte
2005-05-30 23:07   ` Oliver Neukum
2005-05-31  8:06     ` Harald Welte [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050531080609.GI25536@sunbeam.de.gnumonks.org \
    --to=laforge@gnumonks.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=oliver@neukum.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox