Re: pcdp-build-fix.patch added to -mm tree

Re: pcdp-build-fix.patch added to -mm tree

[Alexey Dobriyan]

On Tuesday 31 May 2005 13:24, akpm@osdl.org wrote:
> --- 25/drivers/firmware/pcdp.c~pcdp-build-fix
> +++ 25-akpm/drivers/firmware/pcdp.c
> @@ -11,6 +11,7 @@
>   * published by the Free Software Foundation.
>   */
>  
> +#include <linux/config.h>
>  #include <linux/acpi.h>

Does this patch make sense?
===========================
Recent restoration of quirk_via_irqpic() #ifdef'fed whole include/linux/acpi.h
with CONFIG_ACPI. So, if acpi.h is unlucky enough to be included before
config.h, bad things happen:

		[tested, patch fixes the warning]

	drivers/serial/8250_acpi.c: In function `acpi_serial_ext_irq':
	drivers/serial/8250_acpi.c:51: warning: implicit declaration of
	function `acpi_register_gsi'

or even

		[untested]

	In file included from drivers/firmware/pcdp.c:18:
	drivers/firmware/pcdp.h:48: error: field 'addr' has incomplete type

Signed-off-by: Alexey Dobriyan <adobriyan@gmail.com>

--- linux-vanilla/include/linux/acpi.h	2005-05-28 02:59:59.000000000 +0400
+++ linux-8250/include/linux/acpi.h	2005-05-28 03:39:25.000000000 +0400
@@ -25,6 +25,8 @@
 #ifndef _LINUX_ACPI_H
 #define _LINUX_ACPI_H
 
+#include <linux/config.h>
+
 #ifdef	CONFIG_ACPI
 
 #ifndef _LINUX

Re: pcdp-build-fix.patch added to -mm tree

[Adrian Bunk]

On Tue, May 31, 2005 at 08:22:44PM +0400, Alexey Dobriyan wrote:
> 
> Does this patch make sense?
>...
> --- linux-vanilla/include/linux/acpi.h	2005-05-28 02:59:59.000000000 +0400
> +++ linux-8250/include/linux/acpi.h	2005-05-28 03:39:25.000000000 +0400
> @@ -25,6 +25,8 @@
>  #ifndef _LINUX_ACPI_H
>  #define _LINUX_ACPI_H
>  
> +#include <linux/config.h>
> +
>...

Len said one month ago that he applied a patch from me that included 
both this change and a similar one in acpi_bus.h .

Are there any problems with getting recent ACPI code into -mm?

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed