public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Greg KH <greg@kroah.com>
To: Paul Fulghum <paulkf@microgate.com>
Cc: Alexey Dobriyan <adobriyan@gmail.com>,
	Andrew Morton <akpm@osdl.org>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Introduce tty_unregister_ldisc()
Date: Tue, 31 May 2005 21:39:18 -0700	[thread overview]
Message-ID: <20050601043918.GA26532@kroah.com> (raw)
In-Reply-To: <1117578491.4627.14.camel@at2.pipehead.org>

On Tue, May 31, 2005 at 05:28:11PM -0500, Paul Fulghum wrote:
> This patch is wrong. Please do not apply.
> 
> An unmodified ldisc driver (externally maintained) will continue to call
> tty_register_ldisc with NULL, but the new behavior will be to set the
> ldisc pointer to NULL but have LDISC_FLAG_DEFINED set.

Then fix that code.  We can not do anything about externally maintained
code, sorry.  

> If you feel it is absolutely necessary to add this new function
> for cosmetic reasons, then leave the old behavior in place
> and make tty_unregister_ldisc a wrapper to tty_register_ldisc
> that uses a NULL pointer.
> 
> This preserves sanity and compatibility.

We don't care about compatibility in order to keep our sanity.  See
Documentation/stable_api_nonsense.txt for details :)

thanks,

greg k-h

  parent reply	other threads:[~2005-06-01  4:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-31 19:56 [PATCH 1/2] Introduce tty_unregister_ldisc() Alexey Dobriyan
2005-05-31 22:28 ` Paul Fulghum
2005-06-01  3:38   ` Paul Fulghum
2005-06-01 13:51     ` Paul Fulghum
2005-06-01  4:39   ` Greg KH [this message]
2005-06-01  5:42   ` Christoph Hellwig
2005-06-01 15:22     ` Alexey Dobriyan
  -- strict thread matches above, loose matches on Subject: below --
2005-06-15 21:40 Alexey Dobriyan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050601043918.GA26532@kroah.com \
    --to=greg@kroah.com \
    --cc=adobriyan@gmail.com \
    --cc=akpm@osdl.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=paulkf@microgate.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox