From: Ingo Molnar <mingo@elte.hu>
To: Daniel Walker <dwalker@mvista.com>
Cc: linux-kernel@vger.kernel.org,
Inaky Perez-Gonzalez <inaky.perez-gonzalez@intel.com>,
Oleg Nesterov <oleg@tv-sign.ru>
Subject: Re: [patch] Real-Time Preemption, -RT-2.6.12-rc4-V0.7.47-06
Date: Wed, 1 Jun 2005 15:11:30 +0200 [thread overview]
Message-ID: <20050601131130.GC32232@elte.hu> (raw)
In-Reply-To: <Pine.LNX.4.10.10506010559050.23911-100000@godzilla.mvista.com>
* Daniel Walker <dwalker@mvista.com> wrote:
> > > > existing_sp_head:
> > > > itr_pl2 = container_of(itr_pl->dp_node.prev, struct plist, dp_node);
> > > > list_add(&pl->sp_node, &itr_pl2->sp_node);
> > >
> > > This breaks fifo ordering.
> >
> > Daniel, is the issue (and other issues) Oleg noticed still present? I'm
> > still a bit uneasy about the complexity of the plist changes.
>
> I think this one isn't right. We could make a test quite to check
> correctness. Find the errors before they find us. Oleg may even have
> something like that already half done.
>
> Are you concerned with plist as a whole, or just my recent changes?
>
> There is still a problem with plist_for_each() missing the first list
> member, which I need to fix.
plist seems pretty stable now, but i'm still worried about behavioral
correctness. The previous method, while it didnt scale as well, was at
least more obvious to review.
Ingo
next prev parent reply other threads:[~2005-06-01 13:13 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-23 15:05 [patch] Real-Time Preemption, -RT-2.6.12-rc4-V0.7.47-06 Oleg Nesterov
2005-05-23 15:12 ` Daniel Walker
2005-05-23 15:53 ` Oleg Nesterov
2005-05-23 16:48 ` Oleg Nesterov
2005-06-01 9:21 ` Ingo Molnar
2005-06-01 13:04 ` Daniel Walker
2005-06-01 13:11 ` Ingo Molnar [this message]
2005-06-01 13:21 ` Daniel Walker
2005-06-01 14:43 ` Oleg Nesterov
2005-06-01 14:43 ` Daniel Walker
2005-06-01 15:02 ` Oleg Nesterov
2005-06-01 15:05 ` Daniel Walker
2005-06-01 15:47 ` Oleg Nesterov
2005-06-01 15:43 ` Daniel Walker
-- strict thread matches above, loose matches on Subject: below --
2005-05-24 1:47 Perez-Gonzalez, Inaky
2005-05-23 8:26 Ingo Molnar
2005-05-23 9:34 ` Serge Noiraud
2005-05-23 11:23 ` Ingo Molnar
2005-05-23 14:30 ` K.R. Foley
2005-05-24 16:38 ` K.R. Foley
2005-05-25 11:34 ` Ingo Molnar
2005-05-25 11:35 ` Ingo Molnar
2005-05-25 13:28 ` K.R. Foley
2005-05-25 14:03 ` Ingo Molnar
2005-05-25 14:18 ` K.R. Foley
2005-05-25 15:20 ` K.R. Foley
2005-05-26 7:45 ` Ingo Molnar
2005-05-26 10:53 ` K.R. Foley
2005-05-26 15:23 ` K.R. Foley
2005-05-25 20:38 ` Michal Schmidt
2005-05-27 20:46 ` Michal Schmidt
2005-05-28 5:53 ` Ingo Molnar
2005-05-30 9:51 ` Michal Schmidt
2005-05-30 14:38 ` Ingo Molnar
2005-05-30 14:50 ` Ingo Molnar
2005-05-30 16:47 ` Michal Schmidt
2005-05-30 18:09 ` Ingo Molnar
2005-06-01 17:28 ` Esben Nielsen
2005-06-01 9:19 ` Ingo Molnar
2005-06-01 9:32 ` Michal Schmidt
2005-06-01 9:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050601131130.GC32232@elte.hu \
--to=mingo@elte.hu \
--cc=dwalker@mvista.com \
--cc=inaky.perez-gonzalez@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox