From: Michael Halcrow <mhalcrow@us.ibm.com>
To: James Morris <jmorris@redhat.com>
Cc: Greg KH <greg@kroah.com>,
Phillip Hellewell <phillip@hellewell.homeip.net>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] eCryptfs: eCryptfs kernel module
Date: Thu, 2 Jun 2005 07:32:19 -0500 [thread overview]
Message-ID: <20050602123219.GB8855@halcrow.us> (raw)
In-Reply-To: <Xine.LNX.4.44.0506020329050.4151-100000@thoron.boston.redhat.com>
On Thu, Jun 02, 2005 at 03:33:58AM -0400, James Morris wrote:
> Break up your patch and send it in logical chunks, so it can be
> reviewed easily.
In discussions with some developers from JFS and CIFS, it was
suggested that the best thing would be to submit one patch with the
whole contents of the fs/ecryptfs directory, since it is a new
filesystem with no modifications to existing code. What sort of
logical chunks would you consider to be appropriate? Separate patches
for each file (inode.c, file.c, super.c, etc.), which represent sets
of functions for each major VFS object?
Thanks,
Mike
next prev parent reply other threads:[~2005-06-02 12:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-02 5:47 [PATCH 1/3] eCryptfs: eCryptfs kernel module Phillip Hellewell
2005-06-02 7:33 ` Greg KH
2005-06-02 7:33 ` James Morris
2005-06-02 12:32 ` Michael Halcrow [this message]
2005-06-02 14:51 ` Greg KH
2005-06-02 12:28 ` Michael Halcrow
2005-06-02 14:52 ` Greg KH
2005-06-02 16:33 ` James Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20050602123219.GB8855@halcrow.us \
--to=mhalcrow@us.ibm.com \
--cc=greg@kroah.com \
--cc=jmorris@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=phillip@hellewell.homeip.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox